From d15f4de4aecd38423b6c22da89ddb9581a41d981 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Tue, 1 Oct 2019 19:17:12 -0700 Subject: [PATCH] `@0x/contracts-asset-proxy`: Inline `_grantAllowances()` in `Eth2DaiBridge`. --- .../contracts/src/bridges/Eth2DaiBridge.sol | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/contracts/asset-proxy/contracts/src/bridges/Eth2DaiBridge.sol b/contracts/asset-proxy/contracts/src/bridges/Eth2DaiBridge.sol index 28be6df443..d724dc5c51 100644 --- a/contracts/asset-proxy/contracts/src/bridges/Eth2DaiBridge.sol +++ b/contracts/asset-proxy/contracts/src/bridges/Eth2DaiBridge.sol @@ -57,7 +57,7 @@ contract Eth2DaiBridge is IEth2Dai exchange = _getEth2DaiContract(); // Grant an allowance to the exchange to spend `fromTokenAddress` token. - _grantAllowanceForToken(address(exchange), fromTokenAddress); + IERC20Token(fromTokenAddress).approve(address(exchange), uint256(-1)); // Try to sell all of this contract's `fromTokenAddress` token balance. uint256 boughtAmount = _getEth2DaiContract().sellAllAmount( @@ -95,18 +95,6 @@ contract Eth2DaiBridge is return IEth2Dai(ETH2DAI_ADDRESS); } - /// @dev Grants an unlimited allowance to `spender` for `tokenAddress` token. - /// @param spender The spender address. - /// @param tokenAddress The token address. - function _grantAllowanceForToken( - address spender, - address tokenAddress - ) - private - { - IERC20Token(tokenAddress).approve(spender, uint256(-1)); - } - /// @dev Permissively transfers an ERC20 token that may not adhere to /// specs. /// @param tokenAddress The token contract address.