Merge pull request #1178 from 0xProject/fix/linter-improvements

Add --format stylish to tslint and fix linter errors in contract-wrappers.
2018-10-26 13:34:21 -07:00 · 2018-10-26 13:34:21 -07:00 · cc7321cb5b
commit cc7321cb5b
parent ae64fc15e0 e1306f55ed
44 changed files with 78 additions and 62 deletions
--- a/packages/0x.js/package.json
+++ b/packages/0x.js/package.json
@ -18,7 +18,7 @@
        "build": "yarn build:all",
        "build:ci": "yarn build:commonjs",
        "build:all": "run-p build:umd:prod build:commonjs",
-        "lint": "tslint --project . --exclude **/src/generated_contract_wrappers/**/*",
+        "lint": "tslint --format stylish --project .",
        "test:circleci": "run-s test:coverage",
        "rebuild_and_test": "run-s build test",
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
--- a/packages/abi-gen-wrappers/package.json
+++ b/packages/abi-gen-wrappers/package.json
@ -12,7 +12,7 @@
    "scripts": {
        "build": "yarn pre_build && tsc -b",
        "build:ci": "yarn build",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "pre_build": "yarn generate_contract_wrappers",
        "clean": "shx rm -rf lib wrappers",
        "generate_contract_wrappers": "abi-gen --abis  ${npm_package_config_abis} --template ../contract_templates/contract.handlebars --partials '../contract_templates/partials/**/*.handlebars' --output src/generated-wrappers --backend ethers"
--- a/packages/abi-gen/package.json
+++ b/packages/abi-gen/package.json
@ -8,7 +8,7 @@
    "main": "lib/src/index.js",
    "types": "lib/src/index.d.ts",
    "scripts": {
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "clean": "shx rm -rf lib",
        "build": "tsc -b",
        "build:ci": "yarn build",
--- a/packages/assert/package.json
+++ b/packages/assert/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib test_temp",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "run_mocha": "mocha --require source-map-support/register --require make-promises-safe lib/test/**/*_test.js --exit",
        "test": "yarn run_mocha",
        "rebuild_and_test": "run-s clean build test",
--- a/packages/asset-buyer/package.json
+++ b/packages/asset-buyer/package.json
@ -10,7 +10,7 @@
    "scripts": {
        "build": "yarn tsc -b",
        "build:ci": "yarn build",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test": "yarn run_mocha",
        "rebuild_and_test": "run-s clean build test",
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
--- a/packages/base-contract/package.json
+++ b/packages/base-contract/package.json
@ -17,7 +17,7 @@
        "run_mocha": "mocha --require source-map-support/register --require make-promises-safe lib/test/**/*_test.js --bail --exit",
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
        "coverage:report:lcov": "nyc report --reporter=text-lcov > coverage/lcov.info",
-        "lint": "tslint --project . --exclude **/src/contract_wrappers/**/*"
+        "lint": "tslint --format stylish --project ."
    },
    "license": "Apache-2.0",
    "repository": {
--- a/packages/connect/package.json
+++ b/packages/connect/package.json
@ -19,7 +19,7 @@
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib test_temp generated_docs",
        "copy_test_fixtures": "copyfiles -u 2 './test/fixtures/**/*.json' ./lib/test/fixtures",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "run_mocha": "mocha --require source-map-support/register --require make-promises-safe lib/test/**/*_test.js --exit",
        "test": "run-s copy_test_fixtures run_mocha",
        "rebuild_and_test": "run-s clean build test",
--- a/packages/contract-wrappers/CHANGELOG.json
+++ b/packages/contract-wrappers/CHANGELOG.json
@ -1,4 +1,13 @@
 [
+    {
+        "version": "3.0.1",
+        "changes": [
+            {
+                "note": "Fix bug in `ForwarderWrapper` where `feeRecipientAddress` was not correctly normalized.",
+                "pr": 1178
+            }
+        ]
+    },
    {
        "version": "3.0.0",
        "changes": [
--- a/packages/contract-wrappers/package.json
+++ b/packages/contract-wrappers/package.json
@ -13,7 +13,7 @@
    "scripts": {
        "build": "tsc -b",
        "build:ci": "yarn build",
-        "lint": "tslint --project . --exclude **/src/contract_wrappers/**/* --exclude **/lib/**/*",
+        "lint": "tslint --format stylish --project . --exclude **/lib/**/*",
        "test:circleci": "run-s test:coverage",
        "test": "yarn run_mocha",
        "rebuild_and_test": "run-s build test",
--- a/packages/contract-wrappers/src/contract_wrappers/contract_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/contract_wrapper.ts
@ -28,10 +28,10 @@ export abstract class ContractWrapper {
    protected _networkId: number;
    protected _web3Wrapper: Web3Wrapper;
    private _blockAndLogStreamerIfExists: BlockAndLogStreamer<Block, Log> | undefined;
-    private _blockPollingIntervalMs: number;
+    private readonly _blockPollingIntervalMs: number;
    private _blockAndLogStreamIntervalIfExists?: NodeJS.Timer;
-    private _filters: { [filterToken: string]: FilterObject };
-    private _filterCallbacks: {
+    private readonly _filters: { [filterToken: string]: FilterObject };
+    private readonly _filterCallbacks: {
        [filterToken: string]: EventCallback<ContractEventArgs>;
    };
    private _onLogAddedSubscriptionToken: string | undefined;
--- a/packages/contract-wrappers/src/contract_wrappers/erc20_proxy_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/erc20_proxy_wrapper.ts
@ -34,6 +34,9 @@ export class ERC20ProxyWrapper extends ContractWrapper {
     */
    public async getProxyIdAsync(): Promise<AssetProxyId> {
        const ERC20ProxyContractInstance = this._getERC20ProxyContract();
+        // Note(albrow): Below is a TSLint false positive. Code won't compile if
+        // you remove the type assertion.
+        /* tslint:disable-next-line:no-unnecessary-type-assertion */
        const proxyId = (await ERC20ProxyContractInstance.getProxyId.callAsync()) as AssetProxyId;
        return proxyId;
    }
--- a/packages/contract-wrappers/src/contract_wrappers/erc20_token_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/erc20_token_wrapper.ts
@ -18,12 +18,11 @@ import {
 } from '../types';
 import { assert } from '../utils/assert';
 import { constants } from '../utils/constants';
+import { utils } from '../utils/utils';

 import { ContractWrapper } from './contract_wrapper';
 import { ERC20ProxyWrapper } from './erc20_proxy_wrapper';

-const removeUndefinedProperties = _.pickBy;
-
 /**
 * This class includes all the functionality related to interacting with ERC20 token contracts.
 * All ERC20 method calls are supported, along with some convenience methods for getting/setting allowances
@ -32,8 +31,8 @@ const removeUndefinedProperties = _.pickBy;
 export class ERC20TokenWrapper extends ContractWrapper {
    public abi: ContractAbi = ERC20Token.compilerOutput.abi;
    public UNLIMITED_ALLOWANCE_IN_BASE_UNITS = constants.UNLIMITED_ALLOWANCE_IN_BASE_UNITS;
-    private _tokenContractsByAddress: { [address: string]: ERC20TokenContract };
-    private _erc20ProxyWrapper: ERC20ProxyWrapper;
+    private readonly _tokenContractsByAddress: { [address: string]: ERC20TokenContract };
+    private readonly _erc20ProxyWrapper: ERC20ProxyWrapper;
    /**
     * Instantiate ERC20TokenWrapper
     * @param web3Wrapper Web3Wrapper instance to use
@ -108,7 +107,7 @@ export class ERC20TokenWrapper extends ContractWrapper {
        const txHash = await tokenContract.approve.sendTransactionAsync(
            normalizedSpenderAddress,
            amountInBaseUnits,
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                from: normalizedOwnerAddress,
                gas: txOpts.gasLimit,
                gasPrice: txOpts.gasPrice,
@ -278,7 +277,7 @@ export class ERC20TokenWrapper extends ContractWrapper {
        const txHash = await tokenContract.transfer.sendTransactionAsync(
            normalizedToAddress,
            amountInBaseUnits,
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                from: normalizedFromAddress,
                gas: txOpts.gasLimit,
                gasPrice: txOpts.gasPrice,
@ -339,7 +338,7 @@ export class ERC20TokenWrapper extends ContractWrapper {
            normalizedFromAddress,
            normalizedToAddress,
            amountInBaseUnits,
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                from: normalizedSenderAddress,
                gas: txOpts.gasLimit,
                gasPrice: txOpts.gasPrice,
--- a/packages/contract-wrappers/src/contract_wrappers/erc721_proxy_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/erc721_proxy_wrapper.ts
@ -34,6 +34,9 @@ export class ERC721ProxyWrapper extends ContractWrapper {
     */
    public async getProxyIdAsync(): Promise<AssetProxyId> {
        const ERC721ProxyContractInstance = await this._getERC721ProxyContract();
+        // Note(albrow): Below is a TSLint false positive. Code won't compile if
+        // you remove the type assertion.
+        /* tslint:disable-next-line:no-unnecessary-type-assertion */
        const proxyId = (await ERC721ProxyContractInstance.getProxyId.callAsync()) as AssetProxyId;
        return proxyId;
    }
--- a/packages/contract-wrappers/src/contract_wrappers/erc721_token_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/erc721_token_wrapper.ts
@ -18,12 +18,11 @@ import {
 } from '../types';
 import { assert } from '../utils/assert';
 import { constants } from '../utils/constants';
+import { utils } from '../utils/utils';

 import { ContractWrapper } from './contract_wrapper';
 import { ERC721ProxyWrapper } from './erc721_proxy_wrapper';

-const removeUndefinedProperties = _.pickBy;
-
 /**
 * This class includes all the functionality related to interacting with ERC721 token contracts.
 * All ERC721 method calls are supported, along with some convenience methods for getting/setting allowances
@ -31,8 +30,8 @@ const removeUndefinedProperties = _.pickBy;
 */
 export class ERC721TokenWrapper extends ContractWrapper {
    public abi: ContractAbi = ERC721Token.compilerOutput.abi;
-    private _tokenContractsByAddress: { [address: string]: ERC721TokenContract };
-    private _erc721ProxyWrapper: ERC721ProxyWrapper;
+    private readonly _tokenContractsByAddress: { [address: string]: ERC721TokenContract };
+    private readonly _erc721ProxyWrapper: ERC721ProxyWrapper;
    /**
     * Instantiate ERC721TokenWrapper
     * @param web3Wrapper Web3Wrapper instance to use
@ -235,7 +234,7 @@ export class ERC721TokenWrapper extends ContractWrapper {
        const txHash = await tokenContract.setApprovalForAll.sendTransactionAsync(
            normalizedOperatorAddress,
            isApproved,
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                gas: txOpts.gasLimit,
                gasPrice: txOpts.gasPrice,
                from: normalizedOwnerAddress,
@ -295,7 +294,7 @@ export class ERC721TokenWrapper extends ContractWrapper {
        const txHash = await tokenContract.approve.sendTransactionAsync(
            normalizedApprovedAddress,
            tokenId,
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                gas: txOpts.gasLimit,
                gasPrice: txOpts.gasPrice,
                from: tokenOwnerAddress,
@ -366,7 +365,7 @@ export class ERC721TokenWrapper extends ContractWrapper {
            ownerAddress,
            normalizedReceiverAddress,
            tokenId,
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                gas: txOpts.gasLimit,
                gasPrice: txOpts.gasPrice,
                from: normalizedSenderAddress,
--- a/packages/contract-wrappers/src/contract_wrappers/ether_token_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/ether_token_wrapper.ts
@ -8,22 +8,21 @@ import * as _ from 'lodash';

 import { BlockRange, ContractWrappersError, EventCallback, IndexedFilterValues, TransactionOpts } from '../types';
 import { assert } from '../utils/assert';
+import { utils } from '../utils/utils';

 import { ContractWrapper } from './contract_wrapper';
 import { ERC20TokenWrapper } from './erc20_token_wrapper';

-const removeUndefinedProperties = _.pickBy;
-
 /**
 * This class includes all the functionality related to interacting with a wrapped Ether ERC20 token contract.
 * The caller can convert ETH into the equivalent number of wrapped ETH ERC20 tokens and back.
 */
 export class EtherTokenWrapper extends ContractWrapper {
    public abi: ContractAbi = WETH9.compilerOutput.abi;
-    private _etherTokenContractsByAddress: {
+    private readonly _etherTokenContractsByAddress: {
        [address: string]: WETH9Contract;
    } = {};
-    private _erc20TokenWrapper: ERC20TokenWrapper;
+    private readonly _erc20TokenWrapper: ERC20TokenWrapper;
    /**
     * Instantiate EtherTokenWrapper.
     * @param web3Wrapper Web3Wrapper instance to use
@ -67,7 +66,7 @@ export class EtherTokenWrapper extends ContractWrapper {

        const wethContract = await this._getEtherTokenContractAsync(normalizedEtherTokenAddress);
        const txHash = await wethContract.deposit.sendTransactionAsync(
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                from: normalizedDepositorAddress,
                value: amountInWei,
                gas: txOpts.gasLimit,
@ -109,7 +108,7 @@ export class EtherTokenWrapper extends ContractWrapper {
        const wethContract = await this._getEtherTokenContractAsync(normalizedEtherTokenAddress);
        const txHash = await wethContract.withdraw.sendTransactionAsync(
            amountInWei,
-            removeUndefinedProperties({
+            utils.removeUndefinedProperties({
                from: normalizedWithdrawerAddress,
                gas: txOpts.gasLimit,
                gasPrice: txOpts.gasPrice,
--- a/packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts
@ -46,8 +46,8 @@ export class ExchangeWrapper extends ContractWrapper {
    public address: string;
    public zrxTokenAddress: string;
    private _exchangeContractIfExists?: ExchangeContract;
-    private _erc721TokenWrapper: ERC721TokenWrapper;
-    private _erc20TokenWrapper: ERC20TokenWrapper;
+    private readonly _erc721TokenWrapper: ERC721TokenWrapper;
+    private readonly _erc20TokenWrapper: ERC20TokenWrapper;
    /**
     * Instantiate ExchangeWrapper
     * @param web3Wrapper Web3Wrapper instance to use.
--- a/packages/contract-wrappers/src/contract_wrappers/forwarder_wrapper.ts
+++ b/packages/contract-wrappers/src/contract_wrappers/forwarder_wrapper.ts
@ -1,7 +1,7 @@
 import { ForwarderContract } from '@0x/abi-gen-wrappers';
 import { Forwarder } from '@0x/contract-artifacts';
 import { schemas } from '@0x/json-schemas';
-import { AssetProxyId, SignedOrder } from '@0x/types';
+import { SignedOrder } from '@0x/types';
 import { BigNumber } from '@0x/utils';
 import { Web3Wrapper } from '@0x/web3-wrapper';
 import { ContractAbi } from 'ethereum-types';
@ -118,7 +118,7 @@ export class ForwarderWrapper extends ContractWrapper {
                optimizedFeeOrders,
                feeSignatures,
                formattedFeePercentage,
-                feeRecipientAddress,
+                normalizedFeeRecipientAddress,
                {
                    value: ethAmount,
                    from: normalizedTakerAddress,
@ -207,7 +207,7 @@ export class ForwarderWrapper extends ContractWrapper {
                optimizedFeeOrders,
                feeSignatures,
                formattedFeePercentage,
-                feeRecipientAddress,
+                normalizedFeeRecipientAddress,
                {
                    value: ethAmount,
                    from: normalizedTakerAddress,
--- a/packages/contract-wrappers/src/utils/utils.ts
+++ b/packages/contract-wrappers/src/utils/utils.ts
@ -1,5 +1,6 @@
 import { BigNumber } from '@0x/utils';
 import { Web3Wrapper } from '@0x/web3-wrapper';
+import * as _ from 'lodash';

 import { constants } from './constants';

@ -14,4 +15,7 @@ export const utils = {
    numberPercentageToEtherTokenAmountPercentage(percentage: number): BigNumber {
        return Web3Wrapper.toBaseUnitAmount(constants.ONE_AMOUNT, constants.ETHER_TOKEN_DECIMALS).mul(percentage);
    },
+    removeUndefinedProperties<T extends object>(obj: T): Partial<T> {
+        return _.pickBy(obj);
+    },
 };
--- a/packages/contracts/package.json
+++ b/packages/contracts/package.json
@ -23,7 +23,7 @@
        "compile": "sol-compiler --contracts-dir contracts",
        "clean": "shx rm -rf lib generated-artifacts generated-wrappers",
        "generate_contract_wrappers": "abi-gen --abis  ${npm_package_config_abis} --template ../contract_templates/contract.handlebars --partials '../contract_templates/partials/**/*.handlebars' --output generated-wrappers --backend ethers",
-        "lint": "tslint --project . --exclude ./generated-wrappers/**/* --exclude ./generated-artifacts/**/* --exclude **/lib/**/* && yarn lint-contracts",
+        "lint": "tslint --format stylish --project . --exclude ./generated-wrappers/**/* --exclude ./generated-artifacts/**/* --exclude **/lib/**/* && yarn lint-contracts",
        "coverage:report:text": "istanbul report text",
        "coverage:report:html": "istanbul report html && open coverage/index.html",
        "profiler:report:html": "istanbul report html && open coverage/index.html",
--- a/packages/dev-tools-pages/package.json
+++ b/packages/dev-tools-pages/package.json
@ -11,7 +11,7 @@
        "build:ci": "yarn build",
        "build:dev": "../../node_modules/.bin/webpack --mode development",
        "clean": "shx rm -f public/bundle*",
-        "lint": "tslint --project . 'ts/**/*.ts' 'ts/**/*.tsx'",
+        "lint": "tslint --format stylish --project . 'ts/**/*.ts' 'ts/**/*.tsx'",
        "dev": "webpack-dev-server --mode development --content-base public"
    },
    "license": "Apache-2.0",
--- a/packages/dev-utils/package.json
+++ b/packages/dev-utils/package.json
@ -17,7 +17,7 @@
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
        "coverage:report:lcov": "nyc report --reporter=text-lcov > coverage/lcov.info",
        "clean": "shx rm -rf lib",
-        "lint": "tslint --project ."
+        "lint": "tslint --format stylish --project ."
    },
    "license": "Apache-2.0",
    "repository": {
--- a/packages/ethereum-types/package.json
+++ b/packages/ethereum-types/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib generated_docs",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "docs:json": "typedoc --excludePrivate --excludeExternals --target ES5 --tsconfig typedoc-tsconfig.json --json $JSON_FILE_PATH $PROJECT_FILES"
    },
    "config": {
--- a/packages/fill-scenarios/package.json
+++ b/packages/fill-scenarios/package.json
@ -8,7 +8,7 @@
        "build": "yarn tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib src/generated_contract_wrappers",
-        "lint": "tslint --project ."
+        "lint": "tslint --format stylish --project ."
    },
    "license": "Apache-2.0",
    "repository": {
--- a/packages/instant/package.json
+++ b/packages/instant/package.json
@ -16,7 +16,7 @@
        "build:ci": "yarn build",
        "watch_without_deps": "tsc -w",
        "dev": "webpack-dev-server --mode development",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test": "jest",
        "test:coverage": "jest --coverage",
        "rebuild_and_test": "run-s clean build test",
--- a/packages/json-schemas/package.json
+++ b/packages/json-schemas/package.json
@ -10,7 +10,7 @@
    "scripts": {
        "build": "tsc -b",
        "build:ci": "yarn build",
-        "lint": "tslint --project . --exclude **/schemas/**/*",
+        "lint": "tslint --format stylish --project . --exclude **/schemas/**/*",
        "test": "yarn run_mocha",
        "rebuild_and_test": "run-s clean build test",
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
--- a/packages/metacoin/package.json
+++ b/packages/metacoin/package.json
@ -7,7 +7,7 @@
    "private": true,
    "description": "Example solidity project using 0x dev tools",
    "scripts": {
-        "lint": "tslint --project . --exclude **/src/contract_wrappers/**/*",
+        "lint": "tslint --format stylish --project . --exclude **/src/contract_wrappers/**/*",
        "build": "yarn pre_build && tsc -b",
        "build:ci": "yarn build",
        "pre_build": "run-s compile generate_contract_wrappers copy_artifacts",
--- a/packages/migrations/package.json
+++ b/packages/migrations/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "migrate:v2": "run-s build script:migrate:v2",
        "script:migrate:v2": "node ./lib/migrate.js --contracts-version 2.0.0"
    },
--- a/packages/monorepo-scripts/package.json
+++ b/packages/monorepo-scripts/package.json
@ -11,7 +11,7 @@
    "scripts": {
        "build": "tsc -b",
        "build:ci": "yarn build",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "clean": "shx rm -rf lib",
        "test:publish": "run-s build script:publish",
        "find_unused_deps": "run-s build script:find_unused_deps",
--- a/packages/order-utils/package.json
+++ b/packages/order-utils/package.json
@ -17,7 +17,7 @@
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
        "coverage:report:lcov": "nyc report --reporter=text-lcov > coverage/lcov.info",
        "clean": "shx rm -rf lib generated_docs",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "docs:json": "typedoc --excludePrivate --excludeExternals --target ES5 --tsconfig typedoc-tsconfig.json --json $JSON_FILE_PATH $PROJECT_FILES"
    },
    "config": {
--- a/packages/order-watcher/package.json
+++ b/packages/order-watcher/package.json
@ -14,7 +14,7 @@
    "scripts": {
        "build": "yarn tsc -b",
        "build:ci": "yarn build",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test:circleci": "run-s test:coverage",
        "test": "yarn run_mocha",
        "rebuild_and_test": "run-s build test",
--- a/packages/react-docs/package.json
+++ b/packages/react-docs/package.json
@ -8,7 +8,7 @@
    "main": "lib/index.js",
    "types": "lib/index.d.ts",
    "scripts": {
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib"
--- a/packages/react-shared/package.json
+++ b/packages/react-shared/package.json
@ -8,7 +8,7 @@
    "main": "lib/index.js",
    "types": "lib/index.d.ts",
    "scripts": {
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "build": "tsc",
        "build:ci": "yarn build",
        "watch_without_deps": "tsc -w",
--- a/packages/sol-compiler/package.json
+++ b/packages/sol-compiler/package.json
@ -19,7 +19,7 @@
        "coverage:report:lcov": "nyc report --reporter=text-lcov > coverage/lcov.info",
        "clean": "shx rm -rf lib generated_docs",
        "migrate": "npm run build; node lib/src/cli.js migrate",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test:circleci": "yarn test:coverage",
        "docs:json": "typedoc --excludePrivate --excludeExternals --target ES5 --tsconfig typedoc-tsconfig.json --json $JSON_FILE_PATH $PROJECT_FILES"
    },
--- a/packages/sol-cov/package.json
+++ b/packages/sol-cov/package.json
@ -11,7 +11,7 @@
        "build": "yarn pre_build && tsc -b",
        "build:ci": "yarn build",
        "pre_build": "run-s copy_test_fixtures",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test": "run-s compile_test run_mocha",
        "rebuild_and_test": "run-s clean build test",
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
--- a/packages/sol-doc/package.json
+++ b/packages/sol-doc/package.json
@ -11,7 +11,7 @@
        "test:circleci": "yarn test:coverage",
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
        "coverage:report:lcov": "nyc report --reporter=text-lcov > coverage/lcov.info",
-        "lint": "tslint --project . --format stylish",
+        "lint": "tslint --format stylish --project .",
        "clean": "shx rm -rf lib",
        "generate-v1-protocol-docs": "(cd ../contracts/src/1.0.0; node ../../../../node_modules/.bin/sol-doc --contracts-dir . --contracts Exchange/Exchange_v1.sol TokenRegistry/TokenRegistry.sol TokenTransferProxy/TokenTransferProxy_v1.sol) > v1.0.0.json",
        "generate-v2-protocol-docs": "(cd ../contracts/src/2.0.0; node ../../../../node_modules/.bin/sol-doc --contracts-dir . --contracts Exchange/Exchange.sol AssetProxy/ERC20Proxy.sol AssetProxy/ERC721Proxy.sol OrderValidator/OrderValidator.sol Forwarder/Forwarder.sol  AssetProxyOwner/AssetProxyOwner.sol) > v2.0.0.json",
--- a/packages/sol-resolver/package.json
+++ b/packages/sol-resolver/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib",
-        "lint": "tslint --project ."
+        "lint": "tslint --format stylish --project ."
    },
    "repository": {
        "type": "git",
--- a/packages/sra-spec/package.json
+++ b/packages/sra-spec/package.json
@ -10,7 +10,7 @@
    "scripts": {
        "serve": "redoc-cli serve lib/api.json --watch",
        "watch_without_deps": "run-p build:watch serve",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test": "swagger-cli validate lib/api.json",
        "rebuild_and_test": "run-s clean build test",
        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
--- a/packages/subproviders/package.json
+++ b/packages/subproviders/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib generated_docs",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "run_mocha_unit": "mocha --require source-map-support/register --require make-promises-safe lib/test/unit/**/*_test.js --timeout 10000 --bail --exit",
        "run_mocha_integration": "mocha --require source-map-support/register --require make-promises-safe lib/test/integration/**/*_test.js --timeout 10000 --bail --exit",
        "test": "npm run test:unit",
--- a/packages/testnet-faucets/package.json
+++ b/packages/testnet-faucets/package.json
@ -12,7 +12,7 @@
        "build:ci": "yarn build",
        "dev": "node ../../node_modules/gulp/bin/gulp.js run",
        "start": "node ./server/server.js",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "clean": "shx rm -rf server"
    },
    "author": "Fabio Berger",
--- a/packages/tslint-config/package.json
+++ b/packages/tslint-config/package.json
@ -10,7 +10,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib",
-        "lint": "tslint --project ."
+        "lint": "tslint --format stylish --project ."
    },
    "repository": {
        "type": "git",
--- a/packages/types/package.json
+++ b/packages/types/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib",
-        "lint": "tslint --project ."
+        "lint": "tslint --format stylish --project ."
    },
    "license": "Apache-2.0",
    "repository": {
--- a/packages/utils/package.json
+++ b/packages/utils/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test": "yarn run_mocha",
        "test:circleci": "yarn test:coverage",
        "run_mocha": "mocha --require source-map-support/register --require make-promises-safe lib/test/**/*_test.js --bail --exit",
--- a/packages/web3-wrapper/package.json
+++ b/packages/web3-wrapper/package.json
@ -11,7 +11,7 @@
        "build": "tsc -b",
        "build:ci": "yarn build",
        "clean": "shx rm -rf lib generated_docs",
-        "lint": "tslint --project .",
+        "lint": "tslint --format stylish --project .",
        "test": "yarn run_mocha",
        "rebuild_and_test": "run-s clean build test",
        "test:circleci": "yarn test:coverage",
--- a/packages/website/package.json
+++ b/packages/website/package.json
@ -10,7 +10,7 @@
        "build": "node --max_old_space_size=8192 ../../node_modules/.bin/webpack --mode production",
        "build:dev": "../../node_modules/.bin/webpack --mode development",
        "clean": "shx rm -f public/bundle*",
-        "lint": "tslint --project . 'ts/**/*.ts' 'ts/**/*.tsx'",
+        "lint": "tslint --format stylish --project . 'ts/**/*.ts' 'ts/**/*.tsx'",
        "dev": "webpack-dev-server --mode development --content-base public --https",
        "deploy_dogfood": "npm run build; aws s3 sync ./public/. s3://dogfood.0xproject.com --profile 0xproject --region us-east-1 --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers",
        "deploy_staging": "npm run build; aws s3 sync ./public/. s3://staging-0xproject --profile 0xproject --region us-east-1 --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers",