crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1398 from 0xProject/feature/instant/more-error-reporting

Browse Source 
[instant] More aggressive error reporting
This commit is contained in:
Steve Klebanoff
2018-12-05 20:11:23 -08:00
committed by GitHub
parent cae0e02bc6 b0e7b82dd9
commit c185618224
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/instant/src/util/buy_quote_updater.ts
View File

@@ -38,14 +38,11 @@ export const buyQuoteUpdater = {
} catch (error) { } catch (error) {
const errorMessage = assetUtils.assetBuyerErrorMessage(asset, error); const errorMessage = assetUtils.assetBuyerErrorMessage(asset, error);
if (_.isUndefined(errorMessage)) { errorReporter.report(error);
// This is an unknown error, report it to rollbar analytics.trackQuoteError(error.message ? error.message : 'other', baseUnitValue, fetchOrigin);
errorReporter.report(error);
}
if (options.dispatchErrors) { if (options.dispatchErrors) {
dispatch(actions.setQuoteRequestStateFailure()); dispatch(actions.setQuoteRequestStateFailure());
analytics.trackQuoteError(error.message ? error.message : 'other', baseUnitValue, fetchOrigin);
errorFlasher.flashNewErrorMessage(dispatch, errorMessage || 'Error fetching price, please try again'); errorFlasher.flashNewErrorMessage(dispatch, errorMessage || 'Error fetching price, please try again');
} }
return; return;