crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

asset-s: rm refs to quoteExpiry for RFQT tests

Browse Source 
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2582#discussion_r441836846
This commit is contained in:
F. Eugene Aumson 2020-06-17 17:29:35 -04:00
parent 187dd2fdc3
commit b8cc164af1
No known key found for this signature in database
GPG Key ID: 23E6737B1374A24A
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/asset-swapper/test/quote_requestor_test.ts
View File

@ -55,7 +55,7 @@ describe('QuoteRequestor', async () => {
endpoint: 'https://1337.0.0.1', endpoint: 'https://1337.0.0.1',
requestApiKey: apiKey, requestApiKey: apiKey,
requestParams: expectedParams, requestParams: expectedParams,
responseData: { signedOrder: successfulOrder1, quoteExpiry: successfulOrder1.expirationTimeSeconds }, responseData: { signedOrder: successfulOrder1 },
responseCode: StatusCodes.Success, responseCode: StatusCodes.Success,
}); });
// Test out a bad response code, ensure it doesnt cause throw // Test out a bad response code, ensure it doesnt cause throw
@ -92,10 +92,7 @@ describe('QuoteRequestor', async () => {
endpoint: 'https://422.0.0.1', endpoint: 'https://422.0.0.1',
requestApiKey: apiKey, requestApiKey: apiKey,
requestParams: expectedParams, requestParams: expectedParams,
responseData: { responseData: { signedOrder: wrongMakerAssetDataOrder },
signedOrder: wrongMakerAssetDataOrder,
quoteExpiry: wrongMakerAssetDataOrder.expirationTimeSeconds,
},
responseCode: StatusCodes.Success, responseCode: StatusCodes.Success,
}); });
// A successful response code and valid order, but for wrong taker asset data // A successful response code and valid order, but for wrong taker asset data
@ -108,10 +105,7 @@ describe('QuoteRequestor', async () => {
endpoint: 'https://423.0.0.1', endpoint: 'https://423.0.0.1',
requestApiKey: apiKey, requestApiKey: apiKey,
requestParams: expectedParams, requestParams: expectedParams,
responseData: { responseData: { signedOrder: wrongTakerAssetDataOrder },
signedOrder: wrongTakerAssetDataOrder,
quoteExpiry: wrongTakerAssetDataOrder.expirationTimeSeconds,
},
responseCode: StatusCodes.Success, responseCode: StatusCodes.Success,
}); });
// A successful response code and good order but its unsigned // A successful response code and good order but its unsigned
@ -126,7 +120,7 @@ describe('QuoteRequestor', async () => {
endpoint: 'https://424.0.0.1', endpoint: 'https://424.0.0.1',
requestApiKey: apiKey, requestApiKey: apiKey,
requestParams: expectedParams, requestParams: expectedParams,
responseData: { signedOrder: unsignedOrder, quoteExpiry: unsignedOrder.expirationTimeSeconds }, responseData: { signedOrder: unsignedOrder },
responseCode: StatusCodes.Success, responseCode: StatusCodes.Success,
}); });
// A successful response code and good order but for the wrong takerAddress // A successful response code and good order but for the wrong takerAddress
@ -141,10 +135,7 @@ describe('QuoteRequestor', async () => {
endpoint: 'https://425.0.0.1', endpoint: 'https://425.0.0.1',
requestApiKey: apiKey, requestApiKey: apiKey,
requestParams: expectedParams, requestParams: expectedParams,
responseData: { responseData: { signedOrder: orderWithNullTaker },
signedOrder: orderWithNullTaker,
quoteExpiry: orderWithNullTaker.expirationTimeSeconds,
},
responseCode: StatusCodes.Success, responseCode: StatusCodes.Success,
}); });
@ -159,7 +150,7 @@ describe('QuoteRequestor', async () => {
endpoint: 'https://37.0.0.1', endpoint: 'https://37.0.0.1',
requestApiKey: apiKey, requestApiKey: apiKey,
requestParams: expectedParams, requestParams: expectedParams,
responseData: { signedOrder: successfulOrder2, quoteExpiry: successfulOrder2.expirationTimeSeconds }, responseData: { signedOrder: successfulOrder2 },
responseCode: StatusCodes.Success, responseCode: StatusCodes.Success,
}); });