From b8cc164af16c84ab8633fcebd4c23aa9ad884075 Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Wed, 17 Jun 2020 17:29:35 -0400 Subject: [PATCH] asset-s: rm refs to quoteExpiry for RFQT tests Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2582#discussion_r441836846 --- .../test/quote_requestor_test.ts | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/packages/asset-swapper/test/quote_requestor_test.ts b/packages/asset-swapper/test/quote_requestor_test.ts index b4dee6883e..0bd3d82ce2 100644 --- a/packages/asset-swapper/test/quote_requestor_test.ts +++ b/packages/asset-swapper/test/quote_requestor_test.ts @@ -55,7 +55,7 @@ describe('QuoteRequestor', async () => { endpoint: 'https://1337.0.0.1', requestApiKey: apiKey, requestParams: expectedParams, - responseData: { signedOrder: successfulOrder1, quoteExpiry: successfulOrder1.expirationTimeSeconds }, + responseData: { signedOrder: successfulOrder1 }, responseCode: StatusCodes.Success, }); // Test out a bad response code, ensure it doesnt cause throw @@ -92,10 +92,7 @@ describe('QuoteRequestor', async () => { endpoint: 'https://422.0.0.1', requestApiKey: apiKey, requestParams: expectedParams, - responseData: { - signedOrder: wrongMakerAssetDataOrder, - quoteExpiry: wrongMakerAssetDataOrder.expirationTimeSeconds, - }, + responseData: { signedOrder: wrongMakerAssetDataOrder }, responseCode: StatusCodes.Success, }); // A successful response code and valid order, but for wrong taker asset data @@ -108,10 +105,7 @@ describe('QuoteRequestor', async () => { endpoint: 'https://423.0.0.1', requestApiKey: apiKey, requestParams: expectedParams, - responseData: { - signedOrder: wrongTakerAssetDataOrder, - quoteExpiry: wrongTakerAssetDataOrder.expirationTimeSeconds, - }, + responseData: { signedOrder: wrongTakerAssetDataOrder }, responseCode: StatusCodes.Success, }); // A successful response code and good order but its unsigned @@ -126,7 +120,7 @@ describe('QuoteRequestor', async () => { endpoint: 'https://424.0.0.1', requestApiKey: apiKey, requestParams: expectedParams, - responseData: { signedOrder: unsignedOrder, quoteExpiry: unsignedOrder.expirationTimeSeconds }, + responseData: { signedOrder: unsignedOrder }, responseCode: StatusCodes.Success, }); // A successful response code and good order but for the wrong takerAddress @@ -141,10 +135,7 @@ describe('QuoteRequestor', async () => { endpoint: 'https://425.0.0.1', requestApiKey: apiKey, requestParams: expectedParams, - responseData: { - signedOrder: orderWithNullTaker, - quoteExpiry: orderWithNullTaker.expirationTimeSeconds, - }, + responseData: { signedOrder: orderWithNullTaker }, responseCode: StatusCodes.Success, }); @@ -159,7 +150,7 @@ describe('QuoteRequestor', async () => { endpoint: 'https://37.0.0.1', requestApiKey: apiKey, requestParams: expectedParams, - responseData: { signedOrder: successfulOrder2, quoteExpiry: successfulOrder2.expirationTimeSeconds }, + responseData: { signedOrder: successfulOrder2 }, responseCode: StatusCodes.Success, });