From 801004be6635b2ffc04601181db850499e5ee18e Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Wed, 7 Nov 2018 16:06:20 -0800 Subject: [PATCH 1/7] start jsonRpcRequestId at 1, not 0 I'm trying to use the 0x-watcher against a parity websocket rpc and getting an error that I think is the same as https://github.com/ethereum/web3.js/issues/1967 --- packages/web3-wrapper/src/web3_wrapper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web3-wrapper/src/web3_wrapper.ts b/packages/web3-wrapper/src/web3_wrapper.ts index 56877fef3c..effcd78ab2 100644 --- a/packages/web3-wrapper/src/web3_wrapper.ts +++ b/packages/web3-wrapper/src/web3_wrapper.ts @@ -157,7 +157,7 @@ export class Web3Wrapper { this.abiDecoder = new AbiDecoder([]); this._provider = provider; this._txDefaults = txDefaults || {}; - this._jsonRpcRequestId = 0; + this._jsonRpcRequestId = 1; } /** * Get the contract defaults set to the Web3Wrapper instance From 6ef628613e658e90a06cbe5e34f119082e06678e Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Sun, 11 Nov 2018 15:09:59 -0800 Subject: [PATCH 2/7] update changelog --- packages/order-watcher/CHANGELOG.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json index d574f4a184..f93eda5277 100644 --- a/packages/order-watcher/CHANGELOG.json +++ b/packages/order-watcher/CHANGELOG.json @@ -1,4 +1,14 @@ [ + { + "version: "2.2.1", + "changes": [ + { + "note": "start jsonRpcRequestId at 1, not 0", + "pr": 1227 + } + ], + "timestamp": 1541977777 + }, { "version": "2.2.0", "changes": [ From 76b3caa1241a4b35d07b7a5060d7d77649035001 Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Sun, 11 Nov 2018 15:13:42 -0800 Subject: [PATCH 3/7] Update CHANGELOG.json --- packages/order-watcher/CHANGELOG.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json index 38d308b741..840e55698d 100644 --- a/packages/order-watcher/CHANGELOG.json +++ b/packages/order-watcher/CHANGELOG.json @@ -1,6 +1,6 @@ [ { - "version: "2.2.2", + "version": "2.2.2", "changes": [ { "note": "start jsonRpcRequestId at 1, not 0", From 853c77dc092d1e4bef84e89aef4f62cf1b8aa793 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Mon, 12 Nov 2018 09:07:54 -0800 Subject: [PATCH 4/7] Update packages/order-watcher/CHANGELOG.json Co-Authored-By: WyseNynja --- packages/order-watcher/CHANGELOG.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json index 840e55698d..4f3b58f7f5 100644 --- a/packages/order-watcher/CHANGELOG.json +++ b/packages/order-watcher/CHANGELOG.json @@ -3,7 +3,7 @@ "version": "2.2.2", "changes": [ { - "note": "start jsonRpcRequestId at 1, not 0", + "note": "Start jsonRpcRequestId at 1, not 0 as 0 breaks Parity websocket RPC", "pr": 1227 } ], From 08797392e0c3d89289cf7e298c42eedff4de9de0 Mon Sep 17 00:00:00 2001 From: Fabio B Date: Mon, 12 Nov 2018 09:08:02 -0800 Subject: [PATCH 5/7] Update packages/order-watcher/CHANGELOG.json Co-Authored-By: WyseNynja --- packages/order-watcher/CHANGELOG.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json index 4f3b58f7f5..568e39a278 100644 --- a/packages/order-watcher/CHANGELOG.json +++ b/packages/order-watcher/CHANGELOG.json @@ -7,7 +7,6 @@ "pr": 1227 } ], - "timestamp": 1541977777 }, { "version": "2.2.1", From 22f217807d44e364cad6ebe90560326a755cdd11 Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Mon, 12 Nov 2018 09:08:23 -0800 Subject: [PATCH 6/7] Update CHANGELOG.json --- packages/order-watcher/CHANGELOG.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json index 568e39a278..44d3c5aaab 100644 --- a/packages/order-watcher/CHANGELOG.json +++ b/packages/order-watcher/CHANGELOG.json @@ -6,7 +6,7 @@ "note": "Start jsonRpcRequestId at 1, not 0 as 0 breaks Parity websocket RPC", "pr": 1227 } - ], + ] }, { "version": "2.2.1", From cdf78494d5884f44b7459e350e41109beea20d43 Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Mon, 12 Nov 2018 09:12:59 -0800 Subject: [PATCH 7/7] Update CHANGELOG.json --- packages/order-watcher/CHANGELOG.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json index 728c15c9a5..dbb4824fc7 100644 --- a/packages/order-watcher/CHANGELOG.json +++ b/packages/order-watcher/CHANGELOG.json @@ -3,7 +3,7 @@ "version": "2.2.3", "changes": [ { - "note": "Start jsonRpcRequestId at 1, not 0 as 0 breaks Parity websocket RPC", + "note": "Start jsonRpcRequestId at 1, not 0 as 0 breaks the web3.js websocket RPC provider", "pr": 1227 } ]