From ab7689d188c92c6f53a57abe2c28e4b9da953a6c Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Tue, 19 Nov 2019 16:38:12 +1000 Subject: [PATCH] Re-enable affiliate fee --- packages/instant/src/components/buy_button.tsx | 9 ++++++++- packages/instant/src/components/erc20_token_selector.tsx | 5 +++-- .../instant/src/components/zero_ex_instant_provider.tsx | 3 ++- packages/instant/src/index.umd.ts | 7 +++---- packages/instant/src/redux/reducer.ts | 1 + packages/instant/src/types.ts | 6 ++++++ 6 files changed, 23 insertions(+), 8 deletions(-) diff --git a/packages/instant/src/components/buy_button.tsx b/packages/instant/src/components/buy_button.tsx index 2764a547cf..cfd7a76cb8 100644 --- a/packages/instant/src/components/buy_button.tsx +++ b/packages/instant/src/components/buy_button.tsx @@ -97,7 +97,7 @@ export class BuyButton extends React.PureComponent { let txHash: string | undefined; const gasInfo = await gasPriceEstimator.getGasInfoAsync(); const feeRecipient = oc(affiliateInfo).feeRecipient(); - const feePercentage = oc(affiliateInfo).feeRecipient(); + const feePercentage = oc(affiliateInfo).feePercentage(); try { analytics.trackBuyStarted(swapQuote); txHash = await swapQuoteConsumer.executeSwapQuoteOrThrowAsync(swapQuote, { @@ -125,6 +125,13 @@ export class BuyButton extends React.PureComponent { return; } } + // HACK(dekz): Wrappers no longer include decorators which map errors + // like transaction deny + if (e.message && e.message.includes('User denied transaction signature')) { + analytics.trackBuySignatureDenied(swapQuote); + this.props.onSignatureDenied(swapQuote); + return; + } throw e; } const startTimeUnix = new Date().getTime(); diff --git a/packages/instant/src/components/erc20_token_selector.tsx b/packages/instant/src/components/erc20_token_selector.tsx index e50d68aee4..9cfea07320 100644 --- a/packages/instant/src/components/erc20_token_selector.tsx +++ b/packages/instant/src/components/erc20_token_selector.tsx @@ -163,8 +163,9 @@ class TokenSelectorRowIcon extends React.PureComponent; - } else if (TokenIcon !== undefined) { - return ; + // HACK(dekz): Disale Token icon as it is throwing an error in React renderer + // } else if (TokenIcon !== undefined) { + // return ; } else { return ( diff --git a/packages/instant/src/components/zero_ex_instant_provider.tsx b/packages/instant/src/components/zero_ex_instant_provider.tsx index 59cf8476bd..4eda54b288 100644 --- a/packages/instant/src/components/zero_ex_instant_provider.tsx +++ b/packages/instant/src/components/zero_ex_instant_provider.tsx @@ -85,6 +85,7 @@ export class ZeroExInstantProvider extends React.PureComponent; networkId: Network; + affiliateInfo: AffiliateInfo; shouldDisableAnalyticsTracking: boolean; onSuccess?: (txHash: string) => void; }