From a497ddfad2f4e0b42586d97fba7b557b54a58a94 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Tue, 20 Aug 2019 12:50:17 -0400 Subject: [PATCH] `@0x/contracts-exchange`: Update CHANGELOG and run prettier. --- contracts/exchange/CHANGELOG.json | 4 ---- contracts/exchange/test/wrapper_unit_tests.ts | 20 +++++++++++++++---- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/contracts/exchange/CHANGELOG.json b/contracts/exchange/CHANGELOG.json index 1db76c559c..60a03b38a2 100644 --- a/contracts/exchange/CHANGELOG.json +++ b/contracts/exchange/CHANGELOG.json @@ -182,10 +182,6 @@ "note": "Introduce new `marketSellOrdersFillOrKill` and `marketBuyOrdersFillOrKill` functions.", "pr": 2075 }, - { - "note": "Add new rich error types: `IncompleteMarketBuyError` and `IncompleteMarketSellError`.", - "pr": 2075 - }, { "note": "Use `abi.decode()` in `LibExchangeRichErrorDecoder` over `LibBytes`.", "pr": 2075 diff --git a/contracts/exchange/test/wrapper_unit_tests.ts b/contracts/exchange/test/wrapper_unit_tests.ts index 71b835adf1..6f63d068fb 100644 --- a/contracts/exchange/test/wrapper_unit_tests.ts +++ b/contracts/exchange/test/wrapper_unit_tests.ts @@ -880,12 +880,18 @@ blockchainTests('Exchange wrapper functions unit tests.', env => { order.salt = ALWAYS_FAILING_SALT; } const signatures = _.times(COUNT, i => createOrderSignature(orders[i])); - const badOrdersAmount = _.reduce(badOrders, (total, o) => o.takerAssetAmount.plus(total), constants.ZERO_AMOUNT); + const badOrdersAmount = _.reduce( + badOrders, + (total, o) => o.takerAssetAmount.plus(total), + constants.ZERO_AMOUNT, + ); const takerAssetFillAmount = _.reduce( orders, (total, o) => o.takerAssetAmount.plus(total), constants.ZERO_AMOUNT, - ).minus(badOrdersAmount).plus(1); + ) + .minus(badOrdersAmount) + .plus(1); const expectedError = new ExchangeRevertErrors.IncompleteFillError( ExchangeRevertErrors.IncompleteFillErrorCode.IncompleteMarketSellOrders, takerAssetFillAmount, @@ -1230,12 +1236,18 @@ blockchainTests('Exchange wrapper functions unit tests.', env => { order.salt = ALWAYS_FAILING_SALT; } const signatures = _.times(COUNT, i => createOrderSignature(orders[i])); - const badOrdersAmount = _.reduce(badOrders, (total, o) => o.makerAssetAmount.plus(total), constants.ZERO_AMOUNT); + const badOrdersAmount = _.reduce( + badOrders, + (total, o) => o.makerAssetAmount.plus(total), + constants.ZERO_AMOUNT, + ); const makerAssetFillAmount = _.reduce( orders, (total, o) => o.makerAssetAmount.plus(total), constants.ZERO_AMOUNT, - ).minus(badOrdersAmount).plus(1); + ) + .minus(badOrdersAmount) + .plus(1); const expectedError = new ExchangeRevertErrors.IncompleteFillError( ExchangeRevertErrors.IncompleteFillErrorCode.IncompleteMarketBuyOrders, makerAssetFillAmount,