diff --git a/.circleci/config.yml b/.circleci/config.yml index b40c3eefcb..28be36b941 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -225,7 +225,8 @@ jobs: keys: - repo-{{ .Environment.CIRCLE_SHA1 }} - run: yarn wsrun test:circleci @0x/contracts-test-utils - - run: yarn wsrun test:circleci @0x/abi-gen + # TODO(dorothy-zbornak): Re-enable after updating this package for 3.0. + # - run: yarn wsrun test:circleci-3.0 @0x/abi-gen - run: yarn wsrun test:circleci @0x/assert - run: yarn wsrun test:circleci @0x/base-contract # TODO(dorothy-zbornak): Re-enable after updating this package for 3.0. @@ -238,10 +239,11 @@ jobs: - run: yarn wsrun test:circleci @0x/subproviders - run: yarn wsrun test:circleci @0x/web3-wrapper - run: yarn wsrun test:circleci @0x/utils - - save_cache: - key: coverage-abi-gen-{{ .Environment.CIRCLE_SHA1 }} - paths: - - ~/repo/packages/abi-gen/coverage/lcov.info + # TODO(dorothy-zbornak): Re-enable after updating this package for 3.0. + # - save_cache: + # key: coverage-abi-gen-{{ .Environment.CIRCLE_SHA1 }} + # paths: + # - ~/repo/packages/abi-gen/coverage/lcov.info - save_cache: key: coverage-assert-{{ .Environment.CIRCLE_SHA1 }} paths: @@ -514,9 +516,10 @@ jobs: - restore_cache: keys: - repo-{{ .Environment.CIRCLE_SHA1 }} - - restore_cache: - keys: - - coverage-abi-gen-{{ .Environment.CIRCLE_SHA1 }} + # TODO(dorothy-zbornak): Re-enable after updating this package for 3.0. + # - restore_cache: + # keys: + # - coverage-abi-gen-{{ .Environment.CIRCLE_SHA1 }} - restore_cache: keys: - coverage-assert-{{ .Environment.CIRCLE_SHA1 }} diff --git a/contracts/asset-proxy/.solhintignore b/contracts/asset-proxy/.solhintignore new file mode 100644 index 0000000000..b51bf4177c --- /dev/null +++ b/contracts/asset-proxy/.solhintignore @@ -0,0 +1,2 @@ +# solhint can't parse `abi.decode` syntax. +contracts/src/ERC1155Proxy.sol diff --git a/contracts/asset-proxy/test/erc1155_proxy.ts b/contracts/asset-proxy/test/erc1155_proxy.ts index 56c4148c8b..3177ac6a9b 100644 --- a/contracts/asset-proxy/test/erc1155_proxy.ts +++ b/contracts/asset-proxy/test/erc1155_proxy.ts @@ -1747,9 +1747,14 @@ describe('ERC1155Proxy', () => { nftNotOwnerBalance, ]; await erc1155Wrapper.assertBalancesAsync(tokenHolders, tokensToTransfer, expectedInitialBalances); + const expectedError = new SafeMathRevertErrors.SafeMathError( + SafeMathRevertErrors.SafeMathErrorCodes.Uint256MultiplicationOverflow, + maxUintValue, + valueMultiplier, + ); // execute transfer // note - this will overflow because we are trying to transfer `maxUintValue * 2` of the 2nd token - await expectTransactionFailedAsync( + await expect( erc1155ProxyWrapper.transferFromAsync( spender, receiver, @@ -1760,8 +1765,7 @@ describe('ERC1155Proxy', () => { receiverCallbackData, authorized, ), - RevertReason.Uint256Overflow, - ); + ).to.revertWith(expectedError); }); it('should revert if transferring > 1 instances of a non-fungible token (valueMultiplier field >1)', async () => { // setup test parameters