From 961cd0825c92afca65802e6becf90af839d9721f Mon Sep 17 00:00:00 2001 From: Lawrence Date: Thu, 14 Mar 2019 12:59:50 -0400 Subject: [PATCH] Add comment to ReentrantERC20Token about proper testing procedure --- contracts/exchange/contracts/test/ReentrantERC20Token.sol | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contracts/exchange/contracts/test/ReentrantERC20Token.sol b/contracts/exchange/contracts/test/ReentrantERC20Token.sol index 3688853426..f382a4a231 100644 --- a/contracts/exchange/contracts/test/ReentrantERC20Token.sol +++ b/contracts/exchange/contracts/test/ReentrantERC20Token.sol @@ -27,6 +27,9 @@ import "../src/interfaces/IExchange.sol"; // solhint-disable no-unused-vars, not-rely-on-time +// @dev Because reentrancy is lazily evaluated, after all reentrant calls have +// been made, all attacks should be crafted to succeed for the reentrancy +/// to be properly detected. contract ReentrantERC20Token is ERC20Token {