crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2492 from 0xProject/fix/instant/constant-polling

Browse Source 
[Fix] Instant call destroyAsync on unmount
This commit is contained in:
David Sun 2020-02-26 19:36:48 -05:00 committed by GitHub
commit 880b9413f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/asset-swapper/src/swap_quoter.ts
View File

@ -466,7 +466,8 @@ export class SwapQuoter {
* Destroys any subscriptions or connections. * Destroys any subscriptions or connections.
*/ */
public async destroyAsync(): Promise<void> { public async destroyAsync(): Promise<void> {
return this.orderbook.destroyAsync(); await this._protocolFeeUtils.destroyAsync();
await this.orderbook.destroyAsync();
} }
/** /**

3
packages/instant/src/components/zero_ex_instant_provider.tsx
View File

@ -153,6 +153,9 @@ export class ZeroExInstantProvider extends React.PureComponent<ZeroExInstantProv
if (this._swapQuoteHeartbeat) { if (this._swapQuoteHeartbeat) {
this._swapQuoteHeartbeat.stop(); this._swapQuoteHeartbeat.stop();
} }
const state = this._store.getState();
// tslint:disable-next-line: no-floating-promises
state.providerState.swapQuoter.destroyAsync();
} }
public render(): React.ReactNode { public render(): React.ReactNode {
return ( return (