Fix comments

This commit is contained in:
Fabio Berger 2018-04-18 15:22:20 +09:00
parent 7a8edb5018
commit 64c5c5eb40
5 changed files with 28 additions and 27 deletions

View File

@ -13,7 +13,7 @@ enum LogEventState {
Added, Added,
} }
/* /**
* The EventWatcher watches for blockchain events at the specified block confirmation * The EventWatcher watches for blockchain events at the specified block confirmation
* depth. * depth.
*/ */

View File

@ -154,13 +154,13 @@ export interface OrderFillRequest {
export type AsyncMethod = (...args: any[]) => Promise<any>; export type AsyncMethod = (...args: any[]) => Promise<any>;
export type SyncMethod = (...args: any[]) => any; export type SyncMethod = (...args: any[]) => any;
/* /**
* orderExpirationCheckingIntervalMs: How often to check for expired orders. Default: 50 * orderExpirationCheckingIntervalMs: How often to check for expired orders. Default=50.
* eventPollingIntervalMs: How often to poll the Ethereum node for new events. Default: 200 * eventPollingIntervalMs: How often to poll the Ethereum node for new events. Default=200.
* expirationMarginMs: Amount of time before order expiry that you'd like to be notified * expirationMarginMs: Amount of time before order expiry that you'd like to be notified
* of an orders expiration. Default: 0 * of an orders expiration. Default=0.
* cleanupJobIntervalMs: How often to run a cleanup job which revalidates all the orders. Defaults: 1h * cleanupJobIntervalMs: How often to run a cleanup job which revalidates all the orders. Default=1hr.
* stateLayer: Optional blockchain state layer OrderWatcher will monitor for new events. Default: latest * stateLayer: Optional blockchain state layer OrderWatcher will monitor for new events. Default=latest.
*/ */
export interface OrderStateWatcherConfig { export interface OrderStateWatcherConfig {
orderExpirationCheckingIntervalMs?: number; orderExpirationCheckingIntervalMs?: number;
@ -170,7 +170,7 @@ export interface OrderStateWatcherConfig {
stateLayer: BlockParamLiteral; stateLayer: BlockParamLiteral;
} }
/* /**
* networkId: The id of the underlying ethereum network your provider is connected to. (1-mainnet, 3-ropsten, 4-rinkeby, 42-kovan, 50-testrpc) * networkId: The id of the underlying ethereum network your provider is connected to. (1-mainnet, 3-ropsten, 4-rinkeby, 42-kovan, 50-testrpc)
* gasPrice: Gas price to use with every transaction * gasPrice: Gas price to use with every transaction
* exchangeContractAddress: The address of an exchange contract to use * exchangeContractAddress: The address of an exchange contract to use
@ -201,7 +201,7 @@ export interface Artifact {
}; };
} }
/* /**
* expectedFillTakerTokenAmount: If specified, the validation method will ensure that the * expectedFillTakerTokenAmount: If specified, the validation method will ensure that the
* supplied order maker has a sufficient allowance/balance to fill this amount of the order's * supplied order maker has a sufficient allowance/balance to fill this amount of the order's
* takerTokenAmount. If not specified, the validation method ensures that the maker has a sufficient * takerTokenAmount. If not specified, the validation method ensures that the maker has a sufficient
@ -211,7 +211,7 @@ export interface ValidateOrderFillableOpts {
expectedFillTakerTokenAmount?: BigNumber; expectedFillTakerTokenAmount?: BigNumber;
} }
/* /**
* defaultBlock: The block up to which to query the blockchain state. Setting this to a historical block number * defaultBlock: The block up to which to query the blockchain state. Setting this to a historical block number
* let's the user query the blockchain's state at an arbitrary point in time. In order for this to work, the * let's the user query the blockchain's state at an arbitrary point in time. In order for this to work, the
* backing Ethereum node must keep the entire historical state of the chain (e.g setting `--pruning=archive` * backing Ethereum node must keep the entire historical state of the chain (e.g setting `--pruning=archive`
@ -221,7 +221,7 @@ export interface MethodOpts {
defaultBlock?: BlockParam; defaultBlock?: BlockParam;
} }
/* /**
* gasPrice: Gas price in Wei to use for a transaction * gasPrice: Gas price in Wei to use for a transaction
* gasLimit: The amount of gas to send with a transaction * gasLimit: The amount of gas to send with a transaction
*/ */
@ -230,9 +230,9 @@ export interface TransactionOpts {
gasLimit?: number; gasLimit?: number;
} }
/* /**
* shouldValidate: Flag indicating whether the library should make attempts to validate a transaction before * shouldValidate: Flag indicating whether the library should make attempts to validate a transaction before
* broadcasting it. For example, order has a valid signature, maker has sufficient funds, etc. Default: true * broadcasting it. For example, order has a valid signature, maker has sufficient funds, etc. Default=true.
*/ */
export interface OrderTransactionOpts extends TransactionOpts { export interface OrderTransactionOpts extends TransactionOpts {
shouldValidate?: boolean; shouldValidate?: boolean;

View File

@ -15,14 +15,14 @@ export interface OrderbookChannel {
close: () => void; close: () => void;
} }
/* /**
* heartbeatInterval: Interval in milliseconds that the orderbook channel should ping the underlying websocket. Default: 15000 * heartbeatInterval: Interval in milliseconds that the orderbook channel should ping the underlying websocket. Default: 15000
*/ */
export interface WebSocketOrderbookChannelConfig { export interface WebSocketOrderbookChannelConfig {
heartbeatIntervalMs?: number; heartbeatIntervalMs?: number;
} }
/* /**
* baseTokenAddress: The address of token designated as the baseToken in the currency pair calculation of price * baseTokenAddress: The address of token designated as the baseToken in the currency pair calculation of price
* quoteTokenAddress: The address of token designated as the quoteToken in the currency pair calculation of price * quoteTokenAddress: The address of token designated as the quoteToken in the currency pair calculation of price
* snapshot: If true, a snapshot of the orderbook will be sent before the updates to the orderbook * snapshot: If true, a snapshot of the orderbook will be sent before the updates to the orderbook

View File

@ -4,7 +4,7 @@ import ethUtil = require('ethereumjs-util');
import * as _ from 'lodash'; import * as _ from 'lodash';
export const crypto = { export const crypto = {
/* /**
* We convert types from JS to Solidity as follows: * We convert types from JS to Solidity as follows:
* BigNumber -> uint256 * BigNumber -> uint256
* number -> uint8 * number -> uint8

View File

@ -6,7 +6,8 @@ export interface LedgerCommunicationClient {
close: () => Promise<void>; close: () => Promise<void>;
} }
/* /**
* Elliptic Curve signature
* The LedgerEthereumClient sends Ethereum-specific requests to the Ledger Nano S * The LedgerEthereumClient sends Ethereum-specific requests to the Ledger Nano S
* It uses an internal LedgerCommunicationClient to relay these requests. Currently * It uses an internal LedgerCommunicationClient to relay these requests. Currently
* NodeJs and Browser communication are supported. * NodeJs and Browser communication are supported.
@ -32,7 +33,7 @@ export interface ECSignatureString {
export type LedgerEthereumClientFactoryAsync = () => Promise<LedgerEthereumClient>; export type LedgerEthereumClientFactoryAsync = () => Promise<LedgerEthereumClient>;
/* /**
* networkId: The ethereum networkId to set as the chainId from EIP155 * networkId: The ethereum networkId to set as the chainId from EIP155
* ledgerConnectionType: Environment in which you wish to connect to Ledger (nodejs or browser) * ledgerConnectionType: Environment in which you wish to connect to Ledger (nodejs or browser)
* derivationPath: Initial derivation path to use e.g 44'/60'/0' * derivationPath: Initial derivation path to use e.g 44'/60'/0'
@ -45,7 +46,7 @@ export interface LedgerSubproviderConfigs {
accountFetchingConfigs?: AccountFetchingConfigs; accountFetchingConfigs?: AccountFetchingConfigs;
} }
/* /**
* addressSearchLimit: The maximum number of addresses to search through, defaults to 1000 * addressSearchLimit: The maximum number of addresses to search through, defaults to 1000
* numAddressesToReturn: Number of addresses to return from 'eth_accounts' call * numAddressesToReturn: Number of addresses to return from 'eth_accounts' call
* shouldAskForOnDeviceConfirmation: Whether you wish to prompt the user on their Ledger * shouldAskForOnDeviceConfirmation: Whether you wish to prompt the user on their Ledger
@ -57,7 +58,7 @@ export interface AccountFetchingConfigs {
shouldAskForOnDeviceConfirmation?: boolean; shouldAskForOnDeviceConfirmation?: boolean;
} }
/* /**
* mnemonic: The string mnemonic seed * mnemonic: The string mnemonic seed
* addressSearchLimit: The maximum number of addresses to search through, defaults to 1000 * addressSearchLimit: The maximum number of addresses to search through, defaults to 1000
* baseDerivationPath: The base derivation path (e.g 44'/60'/0'/0) * baseDerivationPath: The base derivation path (e.g 44'/60'/0'/0)