diff --git a/packages/asset-swapper/CHANGELOG.json b/packages/asset-swapper/CHANGELOG.json index 6ab6da141e..efde233290 100644 --- a/packages/asset-swapper/CHANGELOG.json +++ b/packages/asset-swapper/CHANGELOG.json @@ -25,7 +25,11 @@ { "note": "Add `maxFallbackSlippage` option.", "pr": 2513 - } + }, + { + "note": "Fix fee schedule not being scaled by gas price.", + "pr": 2522 + }, ] }, { diff --git a/packages/asset-swapper/src/utils/swap_quote_calculator.ts b/packages/asset-swapper/src/utils/swap_quote_calculator.ts index 149066ab4c..8f08cc1454 100644 --- a/packages/asset-swapper/src/utils/swap_quote_calculator.ts +++ b/packages/asset-swapper/src/utils/swap_quote_calculator.ts @@ -20,7 +20,7 @@ import { import { fillableAmountsUtils } from './fillable_amounts_utils'; import { MarketOperationUtils } from './market_operation_utils'; import { convertNativeOrderToFullyFillableOptimizedOrders } from './market_operation_utils/orders'; -import { ERC20BridgeSource, OptimizedMarketOrder } from './market_operation_utils/types'; +import { ERC20BridgeSource, GetMarketOrdersOpts, OptimizedMarketOrder } from './market_operation_utils/types'; import { ProtocolFeeUtils } from './protocol_fee_utils'; import { isOrderTakerFeePayableWithMakerAsset, @@ -132,9 +132,9 @@ export class SwapQuoteCalculator { { // Scale fees by gas price. - const _opts = { + const _opts: GetMarketOrdersOpts = { ...opts, - fees: _.mapValues(opts.feeSchedule, v => v.times(gasPrice)), + feeSchedule: _.mapValues(opts.feeSchedule, v => v.times(gasPrice)), }; const firstOrderMakerAssetData = !!prunedOrders[0]