crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1371 from 0xProject/feature/instant/log-decimals-and-add-event-properties

Browse Source 
feat(instant): More event properties for tracking
This commit is contained in:
Steve Klebanoff 2018-12-04 17:20:58 -08:00 committed by GitHub
commit 4e7031e96d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
packages/instant/.DS_Store vendored Normal file
View File

Binary file not shown.

18
packages/instant/src/redux/analytics_middleware.ts
View File

@ -1,10 +1,11 @@
import { AssetProxyId } from '@0x/types';
import { Web3Wrapper } from '@0x/web3-wrapper';
import * as _ from 'lodash';
import { Middleware } from 'redux';
import { ETH_DECIMALS } from '../constants';
import { AccountState, StandardSlidingPanelContent } from '../types';
import { analytics } from '../util/analytics';
import { analytics, AnalyticsEventOptions } from '../util/analytics';
import { Action, ActionTypes } from './actions';
@ -29,9 +30,11 @@ export const analyticsMiddleware: Middleware = store => next => middlewareAction
if (didJustTurnReady) {
analytics.trackAccountReady(ethAddress);
analytics.addUserProperties({ lastKnownEthAddress: ethAddress });
analytics.addEventProperties({ ethAddress });
} else if (didJustUpdateAddress) {
analytics.trackAccountAddressChanged(ethAddress);
analytics.addUserProperties({ lastKnownEthAddress: ethAddress });
analytics.addEventProperties({ ethAddress });
}
}
break;
@ -51,7 +54,8 @@ export const analyticsMiddleware: Middleware = store => next => middlewareAction
curAccount.ethBalanceInWei,
ETH_DECIMALS,
).toString();
analytics.addUserProperties({ ethBalanceInUnitAmount });
analytics.addUserProperties({ lastEthBalanceInUnitAmount: ethBalanceInUnitAmount });
analytics.addEventProperties({ ethBalanceInUnitAmount });
}
break;
case ActionTypes.UPDATE_SELECTED_ASSET:
@ -63,10 +67,16 @@ export const analyticsMiddleware: Middleware = store => next => middlewareAction
assetName,
assetData,
});
analytics.addEventProperties({
const selectedAssetEventProperties: AnalyticsEventOptions = {
selectedAssetName: assetName,
selectedAssetData: assetData,
});
};
if (selectedAsset.metaData.assetProxyId === AssetProxyId.ERC20) {
selectedAssetEventProperties.selectedAssetDecimals = selectedAsset.metaData.decimals;
selectedAssetEventProperties.selectedAssetSymbol = selectedAsset.metaData.symbol;
}
analytics.addEventProperties(selectedAssetEventProperties);
}
break;
case ActionTypes.SET_AVAILABLE_ASSETS:

6
packages/instant/src/util/analytics.ts
View File

@ -97,11 +97,13 @@ const buyQuoteEventProperties = (buyQuote: BuyQuote) => {
export interface AnalyticsUserOptions {
lastKnownEthAddress?: string;
ethBalanceInUnitAmount?: string;
lastEthBalanceInUnitAmount?: string;
}
export interface AnalyticsEventOptions {
embeddedHost?: string;
embeddedUrl?: string;
ethBalanceInUnitAmount?: string;
ethAddress?: string;
networkId?: number;
providerName?: string;
gitSha?: string;
@ -112,7 +114,9 @@ export interface AnalyticsEventOptions {
affiliateFeePercent?: number;
numberAvailableAssets?: number;
selectedAssetName?: string;
selectedAssetSymbol?: string;
selectedAssetData?: string;
selectedAssetDecimals?: number;
}
export enum TokenSelectorClosedVia {
ClickedX = 'Clicked X',