From 3de13967bcb7d0d6bf9ae24e78e9367eb78e8db2 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Sat, 18 May 2019 03:18:47 -0400 Subject: [PATCH] `@0x/base-contract`: Re-wrap `StringRevertError`s as plain `Error`s for backwards compatibility --- packages/base-contract/src/index.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/base-contract/src/index.ts b/packages/base-contract/src/index.ts index 832347d637..a730d8a6e0 100644 --- a/packages/base-contract/src/index.ts +++ b/packages/base-contract/src/index.ts @@ -8,6 +8,7 @@ import { decodeThrownErrorAsRevertError, providerUtils, RevertError, + StringRevertError, } from '@0x/utils'; import { Web3Wrapper } from '@0x/web3-wrapper'; import { @@ -128,6 +129,10 @@ export class BaseContract { let revertError: RevertError; try { revertError = decodeThrownErrorAsRevertError(error); + // Re-cast StringRevertErrors as plain Errors for backwards-compatibility. + if (revertError instanceof StringRevertError) { + throw new Error(revertError.values.message as string); + } } catch (err) { // Can't decode it. return;