From 3832c66ad02fa8c9c0cb29cea9167f2d344bcbc5 Mon Sep 17 00:00:00 2001 From: fabioberger Date: Thu, 3 Oct 2019 15:08:05 +0800 Subject: [PATCH] Exclude unready packages from install step as well --- packages/monorepo-scripts/src/test_installation.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/monorepo-scripts/src/test_installation.ts b/packages/monorepo-scripts/src/test_installation.ts index b5a8ca93c4..3da5283cdb 100644 --- a/packages/monorepo-scripts/src/test_installation.ts +++ b/packages/monorepo-scripts/src/test_installation.ts @@ -12,11 +12,12 @@ import { Changelog, Package } from './types'; import { utils } from './utils/utils'; // Packages might not be runnable if they are command-line tools or only run in browsers. +const UNRUNNABLE_PACKAGES = ['@0x/abi-gen']; // HACK(fabio): Temporarily adding '@0x/contracts-coordinator', '@0x/contracts-extensions' since they // aren't working in the V3 branch yet. // TODO(dorothy-zbornak): Remove '@0x/contracts-coordinator', '@0x/contracts-extensions' after updating // these packages for 3.0. -const UNRUNNABLE_PACKAGES = ['@0x/abi-gen', '@0x/contracts-coordinator', '@0x/contracts-extensions']; +const UNINSTALLABLE_PACKAGES = ['@0x/contracts-coordinator', '@0x/contracts-extensions']; const mkdirpAsync = promisify(mkdirp); const rimrafAsync = promisify(rimraf); @@ -57,7 +58,12 @@ function logIfDefined(x: any): void { const packages = utils.getTopologicallySortedPackages(monorepoRootPath); const installablePackages = _.filter( packages, - pkg => !pkg.packageJson.private && pkg.packageJson.main !== undefined && pkg.packageJson.main.endsWith('.js'), + pkg => { + return !pkg.packageJson.private && + pkg.packageJson.main !== undefined && + pkg.packageJson.main.endsWith('.js') && + !UNINSTALLABLE_PACKAGES.includes(pkg.packageJson.name); + }, ); const CHUNK_SIZE = 15; const chunkedInstallablePackages = _.chunk(installablePackages, CHUNK_SIZE);