crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use BigNumber instead of string where appropriate in OrderConfigRequest

Browse Source
This commit is contained in:
fragosti 2018-09-04 14:44:56 -07:00
parent 3524efc41c
commit 33a45fa739
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/connect/src/types.ts
View File

@ -126,12 +126,12 @@ export interface PaginatedCollection<T> {
export interface OrderConfigRequest { export interface OrderConfigRequest {
makerAddress: string; makerAddress: string;
takerAddress: string; takerAddress: string;
makerAssetAmount: string; makerAssetAmount: BigNumber;
takerAssetAmount: string; takerAssetAmount: BigNumber;
makerAssetData: string; makerAssetData: string;
takerAssetData: string; takerAssetData: string;
exchangeAddress: string; exchangeAddress: string;
expirationTimeSeconds: string; expirationTimeSeconds: BigNumber;
} }
export interface OrderConfigResponse { export interface OrderConfigResponse {

7
packages/connect/test/http_client_test.ts
View File

@ -18,6 +18,7 @@ import { orderbookResponse } from './fixtures/standard_relayer_api/orderbook';
import * as orderbookJSON from './fixtures/standard_relayer_api/orderbook.json'; import * as orderbookJSON from './fixtures/standard_relayer_api/orderbook.json';
import { ordersResponse } from './fixtures/standard_relayer_api/orders'; import { ordersResponse } from './fixtures/standard_relayer_api/orders';
import * as ordersResponseJSON from './fixtures/standard_relayer_api/orders.json'; import * as ordersResponseJSON from './fixtures/standard_relayer_api/orders.json';
import { BigNumber } from 'bignumber.js';
chai.config.includeStack = true; chai.config.includeStack = true;
chai.use(dirtyChai); chai.use(dirtyChai);
@ -138,9 +139,9 @@ describe('HttpClient', () => {
const request = { const request = {
makerAddress: '0x9e56625509c2f60af937f23b7b532600390e8c8b', makerAddress: '0x9e56625509c2f60af937f23b7b532600390e8c8b',
takerAddress: '0xa2b31dacf30a9c50ca473337c01d8a201ae33e32', takerAddress: '0xa2b31dacf30a9c50ca473337c01d8a201ae33e32',
makerAssetAmount: '10000000000000000', makerAssetAmount: new BigNumber('10000000000000000'),
takerAssetAmount: '20000000000000000', takerAssetAmount: new BigNumber('20000000000000000'),
expirationTimeSeconds: '1532560590', expirationTimeSeconds: new BigNumber('1532560590'),
makerAssetData: '0xf47261b04c32345ced77393b3530b1eed0f346429d', makerAssetData: '0xf47261b04c32345ced77393b3530b1eed0f346429d',
takerAssetData: '0x0257179264389b814a946f3e92105513705ca6b990', takerAssetData: '0x0257179264389b814a946f3e92105513705ca6b990',
exchangeAddress: '0x12459c951127e0c374ff9105dda097662a027093', exchangeAddress: '0x12459c951127e0c374ff9105dda097662a027093',