From 2d29014091d664a9f71930708296da5de99a6b05 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Wed, 22 Jul 2020 11:43:30 -0400 Subject: [PATCH] `@0x/contracts-erc20-bridge-sampler`: address review comments --- .../erc20-bridge-sampler/contracts/src/ApproximateBuys.sol | 1 - .../erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol | 1 - contracts/erc20-bridge-sampler/contracts/src/UniswapSampler.sol | 2 -- 3 files changed, 4 deletions(-) diff --git a/contracts/erc20-bridge-sampler/contracts/src/ApproximateBuys.sol b/contracts/erc20-bridge-sampler/contracts/src/ApproximateBuys.sol index 7df6aef6c1..a6776b3457 100644 --- a/contracts/erc20-bridge-sampler/contracts/src/ApproximateBuys.sol +++ b/contracts/erc20-bridge-sampler/contracts/src/ApproximateBuys.sol @@ -20,7 +20,6 @@ pragma solidity ^0.5.9; pragma experimental ABIEncoderV2; import "@0x/contracts-exchange-libs/contracts/src/LibMath.sol"; -import "@0x/contracts-utils/contracts/src/LibBytes.sol"; contract ApproximateBuys { diff --git a/contracts/erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol b/contracts/erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol index bd0577121e..7028238f61 100644 --- a/contracts/erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol +++ b/contracts/erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol @@ -19,7 +19,6 @@ pragma solidity ^0.5.9; pragma experimental ABIEncoderV2; -import "./ApproximateBuys.sol"; import "./CurveSampler.sol"; import "./Eth2DaiSampler.sol"; import "./KyberSampler.sol"; diff --git a/contracts/erc20-bridge-sampler/contracts/src/UniswapSampler.sol b/contracts/erc20-bridge-sampler/contracts/src/UniswapSampler.sol index 1a0167cc09..7137653daa 100644 --- a/contracts/erc20-bridge-sampler/contracts/src/UniswapSampler.sol +++ b/contracts/erc20-bridge-sampler/contracts/src/UniswapSampler.sol @@ -35,8 +35,6 @@ contract UniswapSampler is { /// @dev Gas limit for Uniswap calls. uint256 constant private UNISWAP_CALL_GAS = 150e3; // 150k - /// @dev Gas limit for UniswapV2 calls. - uint256 constant private UNISWAPV2_CALL_GAS = 150e3; // 150k /// @dev Sample sell quotes from Uniswap. /// @param takerToken Address of the taker token (what to sell).