From 22fc0b43372082999828787d2a3baae4388ffaf8 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Thu, 10 Oct 2019 09:31:53 +0900 Subject: [PATCH] `@0x/contracts-staking`: Add another `LibFixedMath.add()` test. --- contracts/staking/CHANGELOG.json | 9 +++++++++ contracts/staking/test/unit_tests/lib_fixed_math_test.ts | 6 ++++++ 2 files changed, 15 insertions(+) diff --git a/contracts/staking/CHANGELOG.json b/contracts/staking/CHANGELOG.json index 6ffc8f5be0..8e7a3d3a51 100644 --- a/contracts/staking/CHANGELOG.json +++ b/contracts/staking/CHANGELOG.json @@ -1,4 +1,13 @@ [ + { + "version": "1.1.0-beta.1", + "changes": [ + { + "note": "Add more overflow safeguards to `LibFixedMath`", + "pr": "TODO" + } + ] + }, { "version": "1.1.0-beta.0", "changes": [ diff --git a/contracts/staking/test/unit_tests/lib_fixed_math_test.ts b/contracts/staking/test/unit_tests/lib_fixed_math_test.ts index e2f2c8f48c..6dd3a42fdf 100644 --- a/contracts/staking/test/unit_tests/lib_fixed_math_test.ts +++ b/contracts/staking/test/unit_tests/lib_fixed_math_test.ts @@ -291,6 +291,12 @@ blockchainTests('LibFixedMath unit tests', env => { const r = await testContract.add.callAsync(a, b); expect(r).to.bignumber.eq(-1); }); + + it('MAX_FIXED + (MIN_FIXED + int(1)) == 0', async () => { + const [a, b] = [MAX_FIXED_VALUE, MIN_FIXED_VALUE.plus(1)]; + const r = await testContract.add.callAsync(a, b); + expect(r).to.bignumber.eq(0); + }); }); describe('sub()', () => {