crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: Fix EIP712 hashing docs for limit and RFQ orders (#173)

Browse Source
This commit is contained in:
Lawrence Forman 2021-03-16 15:09:00 -04:00 committed by GitHub
parent dabe6fd793
commit 22e1ed35d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
docs/basics/functions.rst
View File

@ -2,7 +2,7 @@
Basic Functionality Basic Functionality
############################### ###############################
Below is a catalog of basic Exchange functionality. For more advanced usage, like meta-transactions and dex aggregation, see the Advanced section. Below is a catalog of basic Exchange functionality. For more advanced usage, like meta-transactions and dex aggregation, see the Advanced section.
+---------------------------------+--------------------------------------------------------------------------+ +---------------------------------+--------------------------------------------------------------------------+
| **Limit Orders** | **Overview** | | **Limit Orders** | **Overview** |
@ -254,8 +254,8 @@ The hash can be manually generated using the following code:
'address verifyingContract)' 'address verifyingContract)'
)), )),
// The EIP712 domain separator values. // The EIP712 domain separator values.
'ZeroEx', keccak256('ZeroEx'),
'1.0.0', keccak256('1.0.0'),
1, // For mainnet 1, // For mainnet
0xDef1C0ded9bec7F1a1670819833240f027b25EfF, // Address of the Exchange Proxy 0xDef1C0ded9bec7F1a1670819833240f027b25EfF, // Address of the Exchange Proxy
)), )),
@ -269,8 +269,8 @@ The hash can be manually generated using the following code:
'uint128 makerAmount,', 'uint128 makerAmount,',
'uint128 takerAmount,', 'uint128 takerAmount,',
'uint128 takerTokenFeeAmount,', 'uint128 takerTokenFeeAmount,',
'address taker,',
'address maker,', 'address maker,',
'address taker,',
'address sender,', 'address sender,',
'address feeRecipient,', 'address feeRecipient,',
'bytes32 pool,', 'bytes32 pool,',
@ -492,8 +492,8 @@ The hash can be manually generated using the following code:
'address verifyingContract)' 'address verifyingContract)'
)), )),
// The EIP712 domain separator values. // The EIP712 domain separator values.
'ZeroEx', keccak256('ZeroEx'),
'1.0.0', keccak256('1.0.0'),
1, // For mainnet 1, // For mainnet
0xDef1C0ded9bec7F1a1670819833240f027b25EfF, // Address of the Exchange Proxy 0xDef1C0ded9bec7F1a1670819833240f027b25EfF, // Address of the Exchange Proxy
)), )),
@ -526,7 +526,7 @@ The hash can be manually generated using the following code:
order.salt order.salt
)) ))
)); ));
registerAllowedRfqOrigins registerAllowedRfqOrigins
-------------------------- --------------------------
@ -582,4 +582,4 @@ This function transfers protocol fees from `Fee Collectors <../architecture/fee_
/// the staking contract. /// the staking contract.
/// @param poolIds Staking pool IDs /// @param poolIds Staking pool IDs
function transferProtocolFeesForPools(bytes32[] calldata poolIds) function transferProtocolFeesForPools(bytes32[] calldata poolIds)
external; external;