From 22e1ed35d31adfc1085dae0bbb02be2825f201ee Mon Sep 17 00:00:00 2001
From: Lawrence Forman <lawrence@0xproject.com>
Date: Tue, 16 Mar 2021 15:09:00 -0400
Subject: [PATCH] docs: Fix EIP712 hashing docs for limit and RFQ orders (#173)

---
 docs/basics/functions.rst | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/docs/basics/functions.rst b/docs/basics/functions.rst
index 6f9e9e2d04..52c61f6576 100644
--- a/docs/basics/functions.rst
+++ b/docs/basics/functions.rst
@@ -2,7 +2,7 @@
 Basic Functionality
 ###############################
 
-Below is a catalog of basic Exchange functionality. For more advanced usage, like meta-transactions and dex aggregation, see the Advanced section. 
+Below is a catalog of basic Exchange functionality. For more advanced usage, like meta-transactions and dex aggregation, see the Advanced section.
 
 +---------------------------------+--------------------------------------------------------------------------+
 | **Limit Orders**                | **Overview**                                                             |
@@ -254,8 +254,8 @@ The hash can be manually generated using the following code:
                 'address verifyingContract)'
             )),
             // The EIP712 domain separator values.
-            'ZeroEx',
-            '1.0.0',
+            keccak256('ZeroEx'),
+            keccak256('1.0.0'),
             1, // For mainnet
             0xDef1C0ded9bec7F1a1670819833240f027b25EfF, // Address of the Exchange Proxy
         )),
@@ -269,8 +269,8 @@ The hash can be manually generated using the following code:
                 'uint128 makerAmount,',
                 'uint128 takerAmount,',
                 'uint128 takerTokenFeeAmount,',
-                'address taker,',
                 'address maker,',
+                'address taker,',
                 'address sender,',
                 'address feeRecipient,',
                 'bytes32 pool,',
@@ -492,8 +492,8 @@ The hash can be manually generated using the following code:
                 'address verifyingContract)'
             )),
             // The EIP712 domain separator values.
-            'ZeroEx',
-            '1.0.0',
+            keccak256('ZeroEx'),
+            keccak256('1.0.0'),
             1, // For mainnet
             0xDef1C0ded9bec7F1a1670819833240f027b25EfF, // Address of the Exchange Proxy
         )),
@@ -526,7 +526,7 @@ The hash can be manually generated using the following code:
             order.salt
         ))
     ));
-    
+
 
 registerAllowedRfqOrigins
 --------------------------
@@ -582,4 +582,4 @@ This function transfers protocol fees from `Fee Collectors <../architecture/fee_
     ///      the staking contract.
     /// @param poolIds Staking pool IDs
     function transferProtocolFeesForPools(bytes32[] calldata poolIds)
-        external;
\ No newline at end of file
+        external;