From 22684ff5ba37cada1600d27f00d73684fc7c1ee7 Mon Sep 17 00:00:00 2001 From: Elena Date: Sun, 20 Nov 2022 11:39:45 +0200 Subject: [PATCH] Switch contributor instructions to use github draft mode for PRs (#618) instead of WIP title --- CONTRIBUTING.md | 4 ++-- PULL_REQUEST_TEMPLATE.md | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 44a429a307..f7b454ad86 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,9 +8,9 @@ We welcome contributions from anyone on the internet and are grateful for even t 2. Clone your fork 3. Follow the [installation & build steps](https://github.com/0xProject/0x-tools#install-dependencies) in the repo's top-level README. 4. Setup the recommended [Development Tooling](#development-tooling). -5. Open a PR with the `[WIP]` flag against the `development` branch and describe the change you are intending to undertake in the PR description. (see [our branch naming conventions](#branch-structure)) +5. Open a [draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/) against the `development` branch and describe the change you are intending to undertake in the PR description. (see [our branch naming conventions](#branch-structure)) -Before removing the `[WIP]` tag and submitting the PR for review, make sure: +Before making the PR "Ready for review", make sure: - It passes our linter checks (`yarn lint`) - It is properly formatted with Prettier (`yarn prettier`) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index bfca7a5769..2049e90c16 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -20,7 +20,6 @@ -- [ ] Prefix PR title with `[WIP]` if necessary. - [ ] Add tests to cover changes as needed. - [ ] Update documentation as needed. - [ ] Add new entries to the relevant CHANGELOG.jsons.