crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixes a few issues with the typing

Browse Source
This commit is contained in:
Daniel Pyrathon 2020-10-07 19:34:12 -07:00
parent 199808dc44
commit 221de054f4
2 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/asset-swapper/src/types.ts
View File

@ -1,4 +1,5 @@
import { BlockParam, ContractAddresses, GethCallOverrides } from '@0x/contract-wrappers';
import { TakerRequestQueryParams } from '@0x/quote-server';
import { SignedOrder } from '@0x/types';
import { BigNumber } from '@0x/utils';
@ -357,9 +358,7 @@ export enum OrderPrunerPermittedFeeTypes {
export interface MockedRfqtFirmQuoteResponse {
endpoint: string;
requestApiKey: string;
requestParams: {
[key: string]: string | undefined;
};
requestParams: TakerRequestQueryParams,
responseData: any;
responseCode: number;
}
@ -370,9 +369,7 @@ export interface MockedRfqtFirmQuoteResponse {
export interface MockedRfqtIndicativeQuoteResponse {
endpoint: string;
requestApiKey: string;
requestParams: {
[key: string]: string | undefined;
};
requestParams: TakerRequestQueryParams,
responseData: any;
responseCode: number;
}

13
packages/asset-swapper/test/quote_requestor_test.ts
View File

@ -1,5 +1,6 @@
import { tokenUtils } from '@0x/dev-utils';
import { assetDataUtils } from '@0x/order-utils';
import { TakerRequestQueryParams } from '@0x/quote-server';
import { StatusCodes } from '@0x/types';
import { BigNumber } from '@0x/utils';
import * as chai from 'chai';
@ -35,11 +36,11 @@ describe('QuoteRequestor', async () => {
// Set up RFQT responses
// tslint:disable-next-line:array-type
const mockedRequests: MockedRfqtFirmQuoteResponse[] = [];
const expectedParams = {
const expectedParams: TakerRequestQueryParams = {
sellTokenAddress: takerToken,
buyTokenAddress: makerToken,
sellAmountBaseUnits: '10000',
buyAmountBaseUnits: undefined,
comparisonPrice: undefined,
takerAddress,
};
// Successful response
@ -209,11 +210,11 @@ describe('QuoteRequestor', async () => {
// Set up RFQT responses
// tslint:disable-next-line:array-type
const mockedRequests: MockedRfqtIndicativeQuoteResponse[] = [];
const expectedParams = {
const expectedParams: TakerRequestQueryParams = {
sellTokenAddress: takerToken,
buyTokenAddress: makerToken,
sellAmountBaseUnits: '10000',
buyAmountBaseUnits: undefined,
comparisonPrice: undefined,
takerAddress,
};
// Successful response
@ -308,11 +309,11 @@ describe('QuoteRequestor', async () => {
// Set up RFQT responses
// tslint:disable-next-line:array-type
const mockedRequests: MockedRfqtIndicativeQuoteResponse[] = [];
const expectedParams = {
const expectedParams: TakerRequestQueryParams = {
sellTokenAddress: takerToken,
buyTokenAddress: makerToken,
buyAmountBaseUnits: '10000',
sellAmountBaseUnits: undefined,
comparisonPrice: undefined,
takerAddress,
};
// Successful response