From 20961ef42ec980358081eeced0c1e0b8b88a980d Mon Sep 17 00:00:00 2001
From: Andy <112491550+abls@users.noreply.github.com>
Date: Sun, 4 Jun 2023 19:32:43 -0400
Subject: [PATCH] Fix usage of expectEmit in MetaTransactionsFeatureV2 tests
 (#727)

* fix MetaTransactionsFeatureV2 tests

* pretty
---
 .../zero-ex/tests/MetaTransactionV2Test.t.sol | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/contracts/zero-ex/tests/MetaTransactionV2Test.t.sol b/contracts/zero-ex/tests/MetaTransactionV2Test.t.sol
index 0942d49151..82e2d6cd66 100644
--- a/contracts/zero-ex/tests/MetaTransactionV2Test.t.sol
+++ b/contracts/zero-ex/tests/MetaTransactionV2Test.t.sol
@@ -263,6 +263,7 @@ contract MetaTransactionTest is LocalTest {
     function test_transformERC20() external {
         bytes memory transformCallData = _transformERC20Call(zrx, dai, USER_ADDRESS);
         IMetaTransactionsFeatureV2.MetaTransactionDataV2 memory mtxData = _getMetaTransaction(transformCallData);
+        LibSignature.Signature memory sig = _mtxSignature(mtxData);
 
         assertEq(dai.balanceOf(USER_ADDRESS), 1e18);
         vm.expectEmit(true, false, false, true);
@@ -273,10 +274,8 @@ contract MetaTransactionTest is LocalTest {
             address(this)
         );
 
-        IMetaTransactionsFeatureV2(address(zeroExDeployed.zeroEx)).executeMetaTransactionV2(
-            mtxData,
-            _mtxSignature(mtxData)
-        );
+        IMetaTransactionsFeatureV2(address(zeroExDeployed.zeroEx)).executeMetaTransactionV2(mtxData, sig);
+
         assertEq(zrx.balanceOf(USER_ADDRESS), 1e18);
         assertEq(dai.balanceOf(USER_ADDRESS), 0);
         assertEq(weth.balanceOf(address(this)), 1);
@@ -285,6 +284,7 @@ contract MetaTransactionTest is LocalTest {
     function test_rfqOrder() external {
         bytes memory callData = _makeTestRfqOrder(zrx, dai, signerAddress, USER_ADDRESS, signerKey);
         IMetaTransactionsFeatureV2.MetaTransactionDataV2 memory mtxData = _getMetaTransaction(callData);
+        LibSignature.Signature memory sig = _mtxSignature(mtxData);
 
         assertEq(dai.balanceOf(USER_ADDRESS), 1e18);
         vm.expectEmit(true, false, false, true);
@@ -295,10 +295,7 @@ contract MetaTransactionTest is LocalTest {
             address(this)
         );
 
-        IMetaTransactionsFeatureV2(address(zeroExDeployed.zeroEx)).executeMetaTransactionV2(
-            mtxData,
-            _mtxSignature(mtxData)
-        );
+        IMetaTransactionsFeatureV2(address(zeroExDeployed.zeroEx)).executeMetaTransactionV2(mtxData, sig);
 
         assertEq(zrx.balanceOf(signerAddress), 0);
         assertEq(zrx.balanceOf(USER_ADDRESS), 1e18);
@@ -310,6 +307,7 @@ contract MetaTransactionTest is LocalTest {
     function test_fillLimitOrder() external {
         bytes memory callData = _makeTestLimitOrder(zrx, dai, signerAddress, USER_ADDRESS, signerKey);
         IMetaTransactionsFeatureV2.MetaTransactionDataV2 memory mtxData = _getMetaTransaction(callData);
+        LibSignature.Signature memory sig = _mtxSignature(mtxData);
 
         assertEq(dai.balanceOf(USER_ADDRESS), 1e18);
         vm.expectEmit(true, false, false, true);
@@ -320,10 +318,7 @@ contract MetaTransactionTest is LocalTest {
             address(this)
         );
 
-        IMetaTransactionsFeatureV2(address(zeroExDeployed.zeroEx)).executeMetaTransactionV2(
-            mtxData,
-            _mtxSignature(mtxData)
-        );
+        IMetaTransactionsFeatureV2(address(zeroExDeployed.zeroEx)).executeMetaTransactionV2(mtxData, sig);
 
         assertEq(zrx.balanceOf(signerAddress), 0);
         assertEq(zrx.balanceOf(USER_ADDRESS), 1e18);