From 1d0dce73662ffbd79ce435ef9cee3bf597c79a17 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Wed, 7 Aug 2019 19:49:22 -0400 Subject: [PATCH] `@0x/contracts-coordinator`: Update for `marketXOrders` name change. `@0x/contracts-coordinator`: Add `MixinCoordinatorApprovalVerifier.sol` to `.solhintignore` because of `abi.decode` issues. --- contracts/coordinator/.solhintignore | 2 ++ .../contracts/src/MixinCoordinatorApprovalVerifier.sol | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 contracts/coordinator/.solhintignore diff --git a/contracts/coordinator/.solhintignore b/contracts/coordinator/.solhintignore new file mode 100644 index 0000000000..7ba7eea62a --- /dev/null +++ b/contracts/coordinator/.solhintignore @@ -0,0 +1,2 @@ +# solhint can't parse `abi.decode` syntax. +contracts/src/MixinCoordinatorApprovalVerifier.sol diff --git a/contracts/coordinator/contracts/src/MixinCoordinatorApprovalVerifier.sol b/contracts/coordinator/contracts/src/MixinCoordinatorApprovalVerifier.sol index 72664f63a1..c0d9a1d07f 100644 --- a/contracts/coordinator/contracts/src/MixinCoordinatorApprovalVerifier.sol +++ b/contracts/coordinator/contracts/src/MixinCoordinatorApprovalVerifier.sol @@ -100,9 +100,7 @@ contract MixinCoordinatorApprovalVerifier is selector == BATCH_FILL_ORDERS_NO_THROW_SELECTOR || selector == BATCH_FILL_OR_KILL_ORDERS_SELECTOR || selector == MARKET_BUY_ORDERS_SELECTOR || - selector == MARKET_BUY_ORDERS_NO_THROW_SELECTOR || - selector == MARKET_SELL_ORDERS_SELECTOR || - selector == MARKET_SELL_ORDERS_NO_THROW_SELECTOR + selector == MARKET_SELL_ORDERS_SELECTOR ) { // Decode all orders // solhint-disable indent