diff --git a/contracts/asset-proxy/test/static_call_proxy.ts b/contracts/asset-proxy/test/static_call_proxy.ts index 52cb50e2c5..55db645fb2 100644 --- a/contracts/asset-proxy/test/static_call_proxy.ts +++ b/contracts/asset-proxy/test/static_call_proxy.ts @@ -95,26 +95,12 @@ describe('StaticCallProxy', () => { const invalidOffsetToAssetData = ethUtil.bufferToHex(paddedTxDataEndBuffer).slice(2); const newAssetData = '0000000000000000000000000000000000000000000000000000000000000304'; const badTxData = `${txData.replace(offsetToAssetData, invalidOffsetToAssetData)}${newAssetData}`; - await expectTransactionFailedAsync( + await expectTransactionFailedWithoutReasonAsync( web3Wrapper.sendTransactionAsync({ to: staticCallProxy.address, from: fromAddress, data: badTxData, }), - RevertReason.InvalidAssetDataEnd, - ); - }); - it('should revert if the length of assetData, excluding the proxyId, is not a multiple of 32', async () => { - const staticCallData = staticCallTarget.noInputFunction.getABIEncodedTransactionData(); - const expectedResultHash = constants.KECCAK256_NULL; - const assetData = `${assetDataUtils.encodeStaticCallAssetData( - staticCallTarget.address, - staticCallData, - expectedResultHash, - )}01`; - await expectTransactionFailedAsync( - staticCallProxy.transferFrom.sendTransactionAsync(assetData, fromAddress, toAddress, amount), - RevertReason.InvalidAssetDataLength, ); }); it('should revert if the length of assetData is less than 100 bytes', async () => { @@ -125,9 +111,8 @@ describe('StaticCallProxy', () => { .slice(0, -128); const assetDataByteLen = (assetData.length - 2) / 2; expect((assetDataByteLen - 4) % 32).to.equal(0); - await expectTransactionFailedAsync( + await expectTransactionFailedWithoutReasonAsync( staticCallProxy.transferFrom.sendTransactionAsync(assetData, fromAddress, toAddress, amount), - RevertReason.InvalidAssetDataLength, ); }); it('should revert if the offset to `staticCallData` points to outside of assetData', async () => { @@ -147,9 +132,8 @@ describe('StaticCallProxy', () => { offsetToStaticCallData, invalidOffsetToStaticCallData, )}${newStaticCallData}`; - await expectTransactionFailedAsync( + await expectTransactionFailedWithoutReasonAsync( staticCallProxy.transferFrom.sendTransactionAsync(badAssetData, fromAddress, toAddress, amount), - RevertReason.InvalidStaticCallDataOffset, ); }); it('should revert if the callTarget attempts to write to state', async () => {