From 162a8121892b55b19e86db26241d32eb31351e14 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Thu, 4 Apr 2019 15:45:29 -0400 Subject: [PATCH] In `@0x/typescript-typings`: Add types for `@0x/dev-utils` chai helpers in `types/@0x`. In `@0x/dev-utils`: remove global typescript types for chai helpers in lieu of defining them in `@0x/typescript-typings` --- packages/dev-utils/src/chai_revert_error.ts | 9 +-------- packages/typescript-typings/CHANGELOG.json | 9 +++++++++ packages/typescript-typings/types/@0x/index.d.ts | 6 ++++++ 3 files changed, 16 insertions(+), 8 deletions(-) create mode 100644 packages/typescript-typings/types/@0x/index.d.ts diff --git a/packages/dev-utils/src/chai_revert_error.ts b/packages/dev-utils/src/chai_revert_error.ts index 7db17d02d5..3ce1025cc5 100644 --- a/packages/dev-utils/src/chai_revert_error.ts +++ b/packages/dev-utils/src/chai_revert_error.ts @@ -1,13 +1,6 @@ import { AnyRevertError, RevertError, StringRevertError } from '@0x/utils'; -// tslint:disable no-namespace only-arrow-functions prefer-conditional-expression -declare global { - export namespace Chai { - export interface Assertion { - revertWith: (expected: string | RevertError) => Promise; - } - } -} +// tslint:disable only-arrow-functions prefer-conditional-expression type ChaiPromiseHandler = (x: any, ...rest: any[]) => Promise; type ChaiAssertHandler = (x: any, ...rest: any[]) => void; diff --git a/packages/typescript-typings/CHANGELOG.json b/packages/typescript-typings/CHANGELOG.json index 8cc3960dd8..f36af2a9ef 100644 --- a/packages/typescript-typings/CHANGELOG.json +++ b/packages/typescript-typings/CHANGELOG.json @@ -1,4 +1,13 @@ [ + { + "version": "4.3.0", + "changes": [ + { + "note": "Add types for `@0x/dev-utils` chai helpers in `types/@0x`", + "pr": TODO + } + ] + }, { "timestamp": 1563006338, "version": "4.2.3", diff --git a/packages/typescript-typings/types/@0x/index.d.ts b/packages/typescript-typings/types/@0x/index.d.ts new file mode 100644 index 0000000000..123fe211f9 --- /dev/null +++ b/packages/typescript-typings/types/@0x/index.d.ts @@ -0,0 +1,6 @@ +// tslint:disable: no-namespace +declare namespace Chai { + interface Assertion { + revertWith: (expected: string | RevertError) => Promise; + } +}