fix: address PR feedback
This commit is contained in:
parent
42e83ae643
commit
09813cb1d8
@ -1,6 +1,6 @@
|
||||
{
|
||||
"domain": "0x-instant-dogfood",
|
||||
"build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod",
|
||||
"build_command": "WEBPACK_OUTPUT_PATH=public yarn build",
|
||||
"upload_directory": "public",
|
||||
"index_key": "index.html",
|
||||
"error_key": "index.html",
|
||||
|
@ -1,6 +1,6 @@
|
||||
{
|
||||
"domain": "0x-instant-staging",
|
||||
"build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod",
|
||||
"build_command": "WEBPACK_OUTPUT_PATH=public yarn build",
|
||||
"upload_directory": "public",
|
||||
"index_key": "index.html",
|
||||
"error_key": "index.html",
|
||||
|
@ -10,7 +10,6 @@
|
||||
"scripts": {
|
||||
"build": "webpack --mode production",
|
||||
"build:ci": "yarn build",
|
||||
"watch_without_deps": "tsc -w",
|
||||
"dev": "webpack-dev-server --mode development",
|
||||
"lint": "tslint --format stylish --project .",
|
||||
"test": "jest",
|
||||
|
@ -112,5 +112,5 @@ export const render = (config: ZeroExInstantConfig, selector: string = DEFAULT_Z
|
||||
};
|
||||
|
||||
// Write version info to the exported object for debugging
|
||||
export const GitSha = process.env.GIT_SHA;
|
||||
export const NpmVersion = process.env.NPM_PACKAGE_VERSION;
|
||||
export const GIT_SHA = process.env.GIT_SHA;
|
||||
export const NPM_VERSION = process.env.NPM_PACKAGE_VERSION;
|
||||
|
@ -3,9 +3,6 @@ const ip = require('ip');
|
||||
const path = require('path');
|
||||
const webpack = require('webpack');
|
||||
|
||||
// The common js bundle (not this one) is built using tsc.
|
||||
// The umd bundle (this one) has a different entrypoint.
|
||||
|
||||
const GIT_SHA = childProcess
|
||||
.execSync('git rev-parse HEAD')
|
||||
.toString()
|
||||
|
Loading…
x
Reference in New Issue
Block a user