crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address PR feedback

Browse Source
This commit is contained in:
fragosti 2018-11-30 11:20:07 -08:00
parent 42e83ae643
commit 09813cb1d8
5 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/instant/.dogfood.discharge.json
View File

@ -1,6 +1,6 @@
{ {
"domain": "0x-instant-dogfood", "domain": "0x-instant-dogfood",
"build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod", "build_command": "WEBPACK_OUTPUT_PATH=public yarn build",
"upload_directory": "public", "upload_directory": "public",
"index_key": "index.html", "index_key": "index.html",
"error_key": "index.html", "error_key": "index.html",

2
packages/instant/.staging.discharge.json
View File

@ -1,6 +1,6 @@
{ {
"domain": "0x-instant-staging", "domain": "0x-instant-staging",
"build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod", "build_command": "WEBPACK_OUTPUT_PATH=public yarn build",
"upload_directory": "public", "upload_directory": "public",
"index_key": "index.html", "index_key": "index.html",
"error_key": "index.html", "error_key": "index.html",

1
packages/instant/package.json
View File

@ -10,7 +10,6 @@
"scripts": { "scripts": {
"build": "webpack --mode production", "build": "webpack --mode production",
"build:ci": "yarn build", "build:ci": "yarn build",
"watch_without_deps": "tsc -w",
"dev": "webpack-dev-server --mode development", "dev": "webpack-dev-server --mode development",
"lint": "tslint --format stylish --project .", "lint": "tslint --format stylish --project .",
"test": "jest", "test": "jest",

4
packages/instant/src/index.umd.ts
View File

@ -112,5 +112,5 @@ export const render = (config: ZeroExInstantConfig, selector: string = DEFAULT_Z
}; };
// Write version info to the exported object for debugging // Write version info to the exported object for debugging
export const GitSha = process.env.GIT_SHA; export const GIT_SHA = process.env.GIT_SHA;
export const NpmVersion = process.env.NPM_PACKAGE_VERSION; export const NPM_VERSION = process.env.NPM_PACKAGE_VERSION;

3
packages/instant/webpack.config.js
View File

@ -3,9 +3,6 @@ const ip = require('ip');
const path = require('path'); const path = require('path');
const webpack = require('webpack'); const webpack = require('webpack');
// The common js bundle (not this one) is built using tsc.
// The umd bundle (this one) has a different entrypoint.
const GIT_SHA = childProcess const GIT_SHA = childProcess
.execSync('git rev-parse HEAD') .execSync('git rev-parse HEAD')
.toString() .toString()