From a6bf834e7687a30ffc23f509ecf8ee30c9aa8c8b Mon Sep 17 00:00:00 2001
From: carlomazzaferro <carlo.mazzaferro@olx.com>
Date: Sat, 30 Oct 2021 00:15:23 +0100
Subject: [PATCH] address PR comments

---
 mev_inspect/block.py | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/mev_inspect/block.py b/mev_inspect/block.py
index 005fd4f..69c4b79 100644
--- a/mev_inspect/block.py
+++ b/mev_inspect/block.py
@@ -40,11 +40,7 @@ async def create_from_block_number(
         return block
 
 
-async def _fetch_block(
-    w3,
-    base_provider,
-    block_number: int,
-) -> Block:
+async def _fetch_block(w3, base_provider, block_number: int, retries: int = 0) -> Block:
     block_json, receipts_json, traces_json, base_fee_per_gas = await asyncio.gather(
         w3.eth.get_block(block_number),
         base_provider.make_request("eth_getBlockReceipts", [block_number]),
@@ -59,10 +55,13 @@ async def _fetch_block(
         traces = [Trace(**trace_json) for trace_json in traces_json["result"]]
     except KeyError as e:
         logger.warning(
-            f"Failed to create objects from block: {block_number}: {e}, retrying in 5..."
+            f"Failed to create objects from block: {block_number}: {e}, retrying: {retries + 1} / 3"
         )
-        await asyncio.sleep(5)
-        return await _fetch_block(w3, base_provider, block_number)
+        if retries < 3:
+            await asyncio.sleep(5)
+            return await _fetch_block(w3, base_provider, block_number, retries)
+        else:
+            raise
 
     return Block(
         block_number=block_number,