From a8856521d723cda407b221bf1c998930e14e27fc Mon Sep 17 00:00:00 2001 From: Luke Van Seters Date: Tue, 15 Feb 2022 12:24:29 -0500 Subject: [PATCH 1/3] Create pull_request_template.md --- pull_request_template.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000..ed3830f --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,15 @@ +## What does this PR do? + +A short description of what the PR does and motivation for the PR (what problem does it solve? why is this new feature good?) + +## Is this related to an open issue? + +Include the issue number if so + +## Testing + +What testing was performed to verify this works? Unit tests are a big plus! + +## Checklist before merging +- [ ] I have read the [contributing guide](https://github.com/flashbots/mev-inspect-py/blob/main/CONTRIBUTING.md) +- [ ] I have installed and run pre-commit hooks From 6af61dac740258072c12f74c9b20f277bc915d2d Mon Sep 17 00:00:00 2001 From: Luke Van Seters Date: Tue, 15 Feb 2022 13:23:39 -0500 Subject: [PATCH 2/3] Update pull_request_template.md --- pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pull_request_template.md b/pull_request_template.md index ed3830f..e590d26 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -13,3 +13,4 @@ What testing was performed to verify this works? Unit tests are a big plus! ## Checklist before merging - [ ] I have read the [contributing guide](https://github.com/flashbots/mev-inspect-py/blob/main/CONTRIBUTING.md) - [ ] I have installed and run pre-commit hooks +- [ ] All tests pass with `./mev test` From 48cf3612bd25c868b3c62273f796cb0f204a87d6 Mon Sep 17 00:00:00 2001 From: Luke Van Seters Date: Wed, 16 Feb 2022 09:19:36 -0500 Subject: [PATCH 3/3] Update pull_request_template.md --- pull_request_template.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index e590d26..29f2b9e 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,16 +1,18 @@ ## What does this PR do? -A short description of what the PR does and motivation for the PR (what problem does it solve? why is this new feature good?) +A short description of what the PR does. -## Is this related to an open issue? +## Related issue -Include the issue number if so +Link to the issue this PR addresses. + +If there isn't already an open issue, create an issue first. This will be our home for discussing the problem itself. ## Testing What testing was performed to verify this works? Unit tests are a big plus! ## Checklist before merging -- [ ] I have read the [contributing guide](https://github.com/flashbots/mev-inspect-py/blob/main/CONTRIBUTING.md) -- [ ] I have installed and run pre-commit hooks +- [ ] Read the [contributing guide](https://github.com/flashbots/mev-inspect-py/blob/main/CONTRIBUTING.md) +- [ ] Installed and ran pre-commit hooks - [ ] All tests pass with `./mev test`