diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f5756dd63..35d404ee2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,7 +13,7 @@ jobs: uses: cypress-io/github-action@v3.0.4 with: browser: chrome - build: npm run build + build: yarn build start: yarn start wait-on: 'http://localhost:3000' env: diff --git a/site/comments.md b/site/comments.md index eff97209e..6877dc3c5 100644 --- a/site/comments.md +++ b/site/comments.md @@ -298,6 +298,10 @@ _______ Question here; why do we need to run `npm run build` ? We are just serving the app here. Is it a NextJs requirement to build the app before it can be served? We did not need it locally. + + +https://github.com/muratkeremozcan/nextjs-cypress/runs/6289265533?check_suite_focus=true#step:3:60 + ______ We need to add `NEXT_PUBLIC_COMMERCE_SEARCH_ENABLED=true` from the above section, since we did this change in the `.env.local` file. @@ -341,4 +345,3 @@ When did we create a `header.spec.js` file? It is possible that one might miss t └── index.js ``` -https://github.com/muratkeremozcan/nextjs-cypress/runs/6289265533?check_suite_focus=true#step:3:60