From 45afbc548eb5fbc4b5a7711cd1f27c6a63deca54 Mon Sep 17 00:00:00 2001 From: Kanji Yomoda Date: Mon, 31 Jul 2023 21:47:02 +0900 Subject: [PATCH 1/3] Fix typo in a comment (#1130) --- components/cart/modal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/cart/modal.tsx b/components/cart/modal.tsx index 7c0c67b19..a6b45b9ae 100644 --- a/components/cart/modal.tsx +++ b/components/cart/modal.tsx @@ -25,7 +25,7 @@ export default function CartModal({ cart }: { cart: Cart | undefined }) { const closeCart = () => setIsOpen(false); useEffect(() => { - // Open cart modal when when quantity changes. + // Open cart modal when quantity changes. if (cart?.totalQuantity !== quantityRef.current) { // But only if it's not already open (quantity also changes when editing items in cart). if (!isOpen) { From 10b1d4bbae6a4576e4f5565236d8b4494f2774a1 Mon Sep 17 00:00:00 2001 From: Kanji Yomoda Date: Mon, 31 Jul 2023 22:30:00 +0900 Subject: [PATCH 2/3] Renames confusing variable name (#1131) --- app/product/[handle]/page.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/product/[handle]/page.tsx b/app/product/[handle]/page.tsx index 63b205c92..815078b56 100644 --- a/app/product/[handle]/page.tsx +++ b/app/product/[handle]/page.tsx @@ -23,17 +23,17 @@ export async function generateMetadata({ if (!product) return notFound(); const { url, width, height, altText: alt } = product.featuredImage || {}; - const hide = !product.tags.includes(HIDDEN_PRODUCT_TAG); + const indexable = !product.tags.includes(HIDDEN_PRODUCT_TAG); return { title: product.seo.title || product.title, description: product.seo.description || product.description, robots: { - index: hide, - follow: hide, + index: indexable, + follow: indexable, googleBot: { - index: hide, - follow: hide + index: indexable, + follow: indexable } }, openGraph: url From 455a7327f34cd87a571db8ead8b5ae761771d9ca Mon Sep 17 00:00:00 2001 From: Michael Novotny Date: Mon, 31 Jul 2023 09:09:56 -0500 Subject: [PATCH 3/3] Fixes mobile tap targets (#1129) Co-authored-by: Lee Robinson --- components/layout/footer-menu.tsx | 4 ++-- components/layout/footer.tsx | 4 ++-- components/layout/navbar/mobile-menu.tsx | 27 +++++++++++++++--------- 3 files changed, 21 insertions(+), 14 deletions(-) diff --git a/components/layout/footer-menu.tsx b/components/layout/footer-menu.tsx index 696f61fc0..4f6387edd 100644 --- a/components/layout/footer-menu.tsx +++ b/components/layout/footer-menu.tsx @@ -15,11 +15,11 @@ const FooterMenuItem = ({ item }: { item: Menu }) => { }, [pathname, item.path]); return ( -
  • +