From 31d3a93ed91029d2686db51bef0f71ebc15bd1fd Mon Sep 17 00:00:00 2001 From: Thomas Frost Date: Fri, 19 Jul 2024 20:21:19 -0700 Subject: [PATCH 1/2] fix(github-actions): Update develop.deploy-functions.yml --- .github/workflows/develop.deploy-functions.yml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/develop.deploy-functions.yml b/.github/workflows/develop.deploy-functions.yml index 043b455a8..17cdadf68 100644 --- a/.github/workflows/develop.deploy-functions.yml +++ b/.github/workflows/develop.deploy-functions.yml @@ -1,5 +1,14 @@ name: '[Develop] Deploy Functions' +env: + COMPANY_NAME: ${{ vars.COMPANY_NAME }} + TWITTER_CREATOR: ${{ vars.TWITTER_CREATOR }} + TWITTER_SITE: ${{ vars.TWITTER_SITE }} + SITE_NAME: ${{ vars.SITE_NAME }} + SHOPIFY_REVALIDATION_SECRET: ${{ secrets.SHOPIFY_REVALIDATION_SECRET }} + SHOPIFY_STOREFRONT_ACCESS_TOKEN: ${{ vars.SHOPIFY_STOREFRONT_ACCESS_TOKEN }} + SHOPIFY_STORE_DOMAIN: ${{ vars.SHOPIFY_STORE_DOMAIN }} + on: push: branches: @@ -32,14 +41,6 @@ jobs: uses: 'google-github-actions/deploy-cloudrun@v2' with: service: ${{ vars.APP_NAME }} - env_vars: |- - COMPANY_NAME=${{ vars.COMPANY_NAME }} - TWITTER_CREATOR=${{ vars.TWITTER_CREATOR }} - TWITTER_SITE=${{ vars.TWITTER_SITE }} - SITE_NAME=${{ vars.SITE_NAME }} - SHOPIFY_REVALIDATION_SECRET=${{ secrets.SHOPIFY_REVALIDATION_SECRET }} - SHOPIFY_STOREFRONT_ACCESS_TOKEN=${{ vars.SHOPIFY_STOREFRONT_ACCESS_TOKEN }} - SHOPIFY_STORE_DOMAIN=${{ vars.SHOPIFY_STORE_DOMAIN }} - name: 'Use output' run: 'curl "${{ steps.deploy.outputs.url }}"' From 6b19c305160b0fc5aff15bf772b7333a0d46a5a5 Mon Sep 17 00:00:00 2001 From: Thomas Frost Date: Sat, 20 Jul 2024 13:52:07 -0700 Subject: [PATCH 2/2] feat(ContentLandingPage): dynamic landing page based on configuration --- .../[ContentLandingPage]}/layout.tsx | 3 - .../[ContentLandingPage]}/page.tsx | 120 +++++++++--------- app/[page]/opengraph-image.tsx | 11 -- app/[page]/page.tsx | 45 ------- app/layout.tsx | 2 - app/search/[collection]/opengraph-image.tsx | 11 -- app/search/[collection]/page.tsx | 47 ------- app/search/layout.tsx | 21 --- app/search/loading.tsx | 15 --- app/search/page.tsx | 39 ------ lib/shopify/index.ts | 88 ++++++++++--- lib/shopify/queries/product.ts | 9 ++ lib/shopify/types.ts | 35 ++++- 13 files changed, 175 insertions(+), 271 deletions(-) rename app/{[page] => (landing)/[ContentLandingPage]}/layout.tsx (77%) rename app/{product/[handle] => (landing)/[ContentLandingPage]}/page.tsx (51%) delete mode 100644 app/[page]/opengraph-image.tsx delete mode 100644 app/[page]/page.tsx delete mode 100644 app/search/[collection]/opengraph-image.tsx delete mode 100644 app/search/[collection]/page.tsx delete mode 100644 app/search/layout.tsx delete mode 100644 app/search/loading.tsx delete mode 100644 app/search/page.tsx diff --git a/app/[page]/layout.tsx b/app/(landing)/[ContentLandingPage]/layout.tsx similarity index 77% rename from app/[page]/layout.tsx rename to app/(landing)/[ContentLandingPage]/layout.tsx index 50614b5b1..52fe67059 100644 --- a/app/[page]/layout.tsx +++ b/app/(landing)/[ContentLandingPage]/layout.tsx @@ -1,12 +1,9 @@ -import Footer from 'components/layout/footer'; - export default function Layout({ children }: { children: React.ReactNode }) { return ( <>
{children}
-