From 5cb03db3ea073dd60ee2365082a30551226c8ca1 Mon Sep 17 00:00:00 2001 From: powerwlsl Date: Sat, 6 Aug 2022 04:28:54 +0900 Subject: [PATCH] Fix sign up error message not showing up --- .../src/api/endpoints/signup/signup.ts | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/packages/bigcommerce/src/api/endpoints/signup/signup.ts b/packages/bigcommerce/src/api/endpoints/signup/signup.ts index 46c071be8..1c626490d 100644 --- a/packages/bigcommerce/src/api/endpoints/signup/signup.ts +++ b/packages/bigcommerce/src/api/endpoints/signup/signup.ts @@ -34,8 +34,8 @@ const signup: SignupEndpoint['handlers']['signup'] = async ({ }) } catch (error) { if (error instanceof BigcommerceApiError && error.status === 422) { - const hasEmailError = '0.email' in error.data?.errors - + const hasEmailError = '.customer_create' in error.data?.errors + const hasPasswordError = '0.password' in error.data?.errors // If there's an error with the email, it most likely means it's duplicated if (hasEmailError) { return res.status(400).json({ @@ -48,6 +48,18 @@ const signup: SignupEndpoint['handlers']['signup'] = async ({ ], }) } + + if (hasPasswordError) { + return res.status(400).json({ + data: null, + errors: [ + { + message: 'Passwords must be longer than 7 chars and include numbers', + code: 'duplicated_email', + }, + ], + }) + } } throw error