From e3bd8411efb827e5bf45b5a4ce9aebec65cd95e9 Mon Sep 17 00:00:00 2001
From: crowetic <jason@crowetic.com>
Date: Thu, 15 May 2025 15:28:57 -0700
Subject: [PATCH] minor fixes and checks for issues

---
 auto-fix-qortal.sh | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/auto-fix-qortal.sh b/auto-fix-qortal.sh
index 473957e..b7192f3 100644
--- a/auto-fix-qortal.sh
+++ b/auto-fix-qortal.sh
@@ -395,9 +395,11 @@ potentially_update_settings() {
     is_valid_json=false
     if command -v jq &>/dev/null; then
         echo "${YELLOW}Using jq to validate JSON...${NC}"
-        if jq empty "${SETTINGS_FILE}" 2>/dev/null; then
-            is_valid_json=true
-            echo "${GREEN}settings.json is valid JSON.${NC}"
+        if [ -s "${SETTINGS_FILE}" ]; then
+            if jq empty "${SETTINGS_FILE}" 2>/dev/null; then
+                is_valid_json=true
+                echo "${GREEN}settings.json is valid JSON.${NC}"
+            fi
         fi
     else
         echo "${YELLOW}jq not found, doing basic manual check...${NC}"
@@ -419,7 +421,7 @@ potentially_update_settings() {
             echo "${GREEN}Backup restored successfully and is valid.${NC}"
         else
             echo "${RED}Backup also invalid. Downloading default settings.json...${NC}"
-            curl -L -O "${SETTINGS_FILE}" "https://raw.githubusercontent.com/crowetic/QORTector-scripts/refs/heads/main/settings.json"
+            curl -L -O "https://raw.githubusercontent.com/crowetic/QORTector-scripts/refs/heads/main/settings.json"
 
             # Final validation
             if command -v jq &>/dev/null && jq empty "${SETTINGS_FILE}" 2>/dev/null; then
@@ -473,7 +475,7 @@ update_script() {
     echo "${YELLOW}Checking for any settings changes required...${NC}"
     sleep 2
     potentially_update_settings
-    rm -rf ${HOME}/qortal.jar ${HOME}/run.pid ${HOME}/run.log ${HOME}/remote.md5 ${HOME}/qortal/local.md5
+    rm -rf "${HOME}/qortal.jar" "${HOME}/run.pid" "${HOME}/run.log" "${HOME}/remote.md5" "${HOME}/qortal/local.md5"
     mkdir -p ${HOME}/backups && mv ${HOME}/qortal/backup-settings* ${HOME}/backups
     echo "${YELLOW}Auto-fix script run complete.${NC}\n"
     sleep 5