forked from Qortal/Brooklyn
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
81 lines
1.6 KiB
81 lines
1.6 KiB
// SPDX-License-Identifier: GPL-2.0-only |
|
/// Find nested lock+irqsave functions that use the same flags variables |
|
/// |
|
// Confidence: High |
|
// Copyright: (C) 2010-2012 Nicolas Palix. |
|
// Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6. |
|
// Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6. |
|
// URL: https://coccinelle.gitlabpages.inria.fr/website |
|
// Comments: |
|
// Options: --no-includes --include-headers |
|
|
|
virtual context |
|
virtual org |
|
virtual report |
|
|
|
@r exists@ |
|
expression lock1,lock2,flags; |
|
position p1,p2; |
|
@@ |
|
|
|
( |
|
spin_lock_irqsave@p1(lock1,flags) |
|
| |
|
read_lock_irqsave@p1(lock1,flags) |
|
| |
|
write_lock_irqsave@p1(lock1,flags) |
|
) |
|
... when != flags |
|
( |
|
spin_lock_irqsave(lock1,flags) |
|
| |
|
read_lock_irqsave(lock1,flags) |
|
| |
|
write_lock_irqsave(lock1,flags) |
|
| |
|
spin_lock_irqsave@p2(lock2,flags) |
|
| |
|
read_lock_irqsave@p2(lock2,flags) |
|
| |
|
write_lock_irqsave@p2(lock2,flags) |
|
) |
|
|
|
@d exists@ |
|
expression f <= r.flags; |
|
expression lock1,lock2,flags; |
|
position r.p1, r.p2; |
|
@@ |
|
|
|
( |
|
*spin_lock_irqsave@p1(lock1,flags) |
|
| |
|
*read_lock_irqsave@p1(lock1,flags) |
|
| |
|
*write_lock_irqsave@p1(lock1,flags) |
|
) |
|
... when != f |
|
( |
|
*spin_lock_irqsave@p2(lock2,flags) |
|
| |
|
*read_lock_irqsave@p2(lock2,flags) |
|
| |
|
*write_lock_irqsave@p2(lock2,flags) |
|
) |
|
|
|
// ---------------------------------------------------------------------- |
|
|
|
@script:python depends on d && org@ |
|
p1 << r.p1; |
|
p2 << r.p2; |
|
@@ |
|
|
|
cocci.print_main("original lock",p1) |
|
cocci.print_secs("nested lock+irqsave that reuses flags",p2) |
|
|
|
@script:python depends on d && report@ |
|
p1 << r.p1; |
|
p2 << r.p2; |
|
@@ |
|
|
|
msg="ERROR: nested lock+irqsave that reuses flags from line %s." % (p1[0].line) |
|
coccilib.report.print_report(p2[0], msg)
|
|
|