From f3e9dfe734e1b56a6eed08832e254647ca32fd19 Mon Sep 17 00:00:00 2001 From: CalDescent Date: Sat, 27 Nov 2021 16:43:29 +0000 Subject: [PATCH] Return a 404 instead of a 500 if a resource is unavailable. Could be improved in the future to return different codes depending on its status (e.g. doesn't exist = 404, 102 for loading, 500 for error, etc), but 404 makes the most sense until that has been developed --- src/main/java/org/qortal/api/resource/ArbitraryResource.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/qortal/api/resource/ArbitraryResource.java b/src/main/java/org/qortal/api/resource/ArbitraryResource.java index 85d580d7..cad871f5 100644 --- a/src/main/java/org/qortal/api/resource/ArbitraryResource.java +++ b/src/main/java/org/qortal/api/resource/ArbitraryResource.java @@ -641,7 +641,7 @@ public class ArbitraryResource { return response; } catch (Exception e) { LOGGER.info(String.format("Unable to load %s %s: %s", service, name, e.getMessage())); - throw ApiExceptionFactory.INSTANCE.createCustomException(request, ApiError.REPOSITORY_ISSUE, e.getMessage()); + throw ApiExceptionFactory.INSTANCE.createCustomException(request, ApiError.FILE_NOT_FOUND, e.getMessage()); } }