From c989e3c41305f2d7024dbf663915a3967b3910e7 Mon Sep 17 00:00:00 2001
From: AlphaX-Projects <77661270+AlphaX-Projects@users.noreply.github.com>
Date: Tue, 12 Dec 2023 10:05:24 +0100
Subject: [PATCH] Rework trustless manager

---
 .../crypto/TrustlessSSLSocketFactory.java     | 27 +++++++++----------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/src/main/java/org/qortal/crypto/TrustlessSSLSocketFactory.java b/src/main/java/org/qortal/crypto/TrustlessSSLSocketFactory.java
index f14efae8..3643e552 100644
--- a/src/main/java/org/qortal/crypto/TrustlessSSLSocketFactory.java
+++ b/src/main/java/org/qortal/crypto/TrustlessSSLSocketFactory.java
@@ -1,33 +1,33 @@
 package org.qortal.crypto;
 
-import javax.net.ssl.SSLContext;
-import javax.net.ssl.SSLSocketFactory;
-import javax.net.ssl.TrustManager;
-import javax.net.ssl.X509TrustManager;
+import javax.net.ssl.*;
 import java.security.cert.X509Certificate;
 
 public abstract class TrustlessSSLSocketFactory {
 
-	// Create a trust manager that does not validate certificate chains
+	/**
+	 * Creates a SSLSocketFactory that ignore certificate chain validation because ElectrumX servers use mostly
+	 * self signed certificates.
+	 */
 	private static final TrustManager[] TRUSTLESS_MANAGER = new TrustManager[] {
 		new X509TrustManager() {
-			public java.security.cert.X509Certificate[] getAcceptedIssuers() {
-				return new X509Certificate[0];
+			public X509Certificate[] getAcceptedIssuers() {
+				return null;
 			}
-
-			public void checkClientTrusted(java.security.cert.X509Certificate[] certs, String authType) {
+			public void checkClientTrusted(X509Certificate[] certs, String authType) {
 			}
-
-			public void checkServerTrusted(java.security.cert.X509Certificate[] certs, String authType) {
+			public void checkServerTrusted(X509Certificate[] certs, String authType) {
 			}
 		}
 	};
 
-	// Install the all-trusting trust manager
+	/**
+	 * Install the all-trusting trust manager.
+	 */
 	private static final SSLContext sc;
 	static {
 		try {
-			sc = SSLContext.getInstance("TLSv1.3");
+			sc = SSLContext.getInstance("SSL");
 			sc.init(null, TRUSTLESS_MANAGER, new java.security.SecureRandom());
 		} catch (Exception e) {
 			throw new RuntimeException(e);
@@ -37,5 +37,4 @@ public abstract class TrustlessSSLSocketFactory {
 	public static SSLSocketFactory getSocketFactory() {
 		return sc.getSocketFactory();
 	}
-
 }