From 4a4678b3314e1f5bac6e7cdc4639792fb7cb611d Mon Sep 17 00:00:00 2001 From: catbref Date: Mon, 16 Mar 2020 16:07:17 +0000 Subject: [PATCH] Immediately close socketChannels after accepting peers we won't use --- src/main/java/org/qortal/network/Network.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/qortal/network/Network.java b/src/main/java/org/qortal/network/Network.java index 4b393c20..c25aaf1e 100644 --- a/src/main/java/org/qortal/network/Network.java +++ b/src/main/java/org/qortal/network/Network.java @@ -481,18 +481,20 @@ public class Network { try { if (now == null) { - LOGGER.debug(String.format("Connection discarded from peer %s due to lack of NTP sync", socketChannel.getRemoteAddress())); + LOGGER.debug(() -> String.format("Connection discarded from peer %s due to lack of NTP sync", PeerAddress.fromSocket(socketChannel.socket()))); + socketChannel.close(); return; } synchronized (this.connectedPeers) { if (connectedPeers.size() >= maxPeers) { // We have enough peers - LOGGER.debug(String.format("Connection discarded from peer %s", socketChannel.getRemoteAddress())); + LOGGER.debug(() -> String.format("Connection discarded from peer %s", PeerAddress.fromSocket(socketChannel.socket()))); + socketChannel.close(); return; } - LOGGER.debug(String.format("Connection accepted from peer %s", socketChannel.getRemoteAddress())); + LOGGER.debug(() -> String.format("Connection accepted from peer %s", PeerAddress.fromSocket(socketChannel.socket()))); newPeer = new Peer(socketChannel); this.connectedPeers.add(newPeer);