Qortal/qortal
1
0
Fork 0
mirror of https://github.com/Qortal/qortal.git synced 2025-04-01 17:55:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update PingTask.java

Browse Source 
* Better exception handling, logging, and minor optimizations for readability and maintainability.
* Improved exception safety ensures unexpected errors during the PING process do not crash the application.
This commit is contained in:
cwd.systems | 0KN 2024-11-27 17:14:12 +06:00 committed by GitHub
parent 8ffb0625a1
commit 421a1a704c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 31 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/main/java/org/qortal/network/task/PingTask.java
View File

@ -14,31 +14,51 @@ public class PingTask implements Task {
private final Peer peer;
private final Long now;
private final String name;
private String name; // Lazy initialization
public PingTask(Peer peer, Long now) {
this.peer = peer;
this.now = now;
this.name = "PingTask::" + peer;
}
@Override
public String getName() {
if (name == null) {
name = "PingTask::" + peer;
}
return name;
}
@Override
public void perform() throws InterruptedException {
PingMessage pingMessage = new PingMessage();
Message message = peer.getResponse(pingMessage);
try {
// Create a PingMessage
PingMessage pingMessage = new PingMessage();
Message responseMessage = peer.getResponse(pingMessage);
if (message == null || message.getType() != MessageType.PING) {
LOGGER.debug("[{}] Didn't receive reply from {} for PING ID {}",
peer.getPeerConnectionId(), peer, pingMessage.getId());
peer.disconnect("no ping received");
return;
// Validate the response
if (responseMessage == null || responseMessage.getType() != MessageType.PING) {
LOGGER.debug("[{}] No PING response received from {} for PING ID {}",
peer.getPeerConnectionId(), peer, pingMessage.getId());
peer.disconnect("No PING response received");
return;
}
// Calculate round-trip time and update peer
long currentTime = NTP.getTime();
if (currentTime == null) {
LOGGER.warn("NTP time unavailable during PING task for peer {}", peer);
peer.disconnect("NTP time unavailable");
return;
}
peer.setLastPing(currentTime - now);
LOGGER.debug("[{}] PING successful with {} (round-trip time: {} ms)",
peer.getPeerConnectionId(), peer, currentTime - now);
} catch (Exception e) {
LOGGER.error("Error during PING task for peer {}: {}", peer, e.getMessage(), e);
peer.disconnect("Error during PING task");
}
peer.setLastPing(NTP.getTime() - now);
}
}