Update Clippy to support latest nightly, and fix some lints.

Cargo.toml

@@ -14,7 +14,7 @@ repository = "https://github.com/ebfull/pairing"
 [dependencies]
 rand = "0.4"
 byteorder = "1"
-clippy = { version = "0.0.186", optional = true }
+clippy = { version = "0.0.190", optional = true }
 
 [features]
 unstable-features = ["expose-arith"]

src/bls12_381/mod.rs

@@ -350,7 +350,7 @@ impl G2Prepared {
         coeffs.push(doubling_step(&mut r));
 
         G2Prepared {
-            coeffs: coeffs,
+            coeffs,
             infinity: false,
         }
     }

src/lib.rs

@@ -563,7 +563,7 @@ impl<E: AsRef<[u64]>> BitIterator<E> {
     pub fn new(t: E) -> Self {
         let n = t.as_ref().len() * 64;
 
-        BitIterator { t: t, n: n }
+        BitIterator { t, n }
     }
 }
 

src/wnaf.rs

@@ -102,7 +102,7 @@ impl<G: CurveProjective> Wnaf<(), Vec<G>, Vec<i64>> {
         Wnaf {
             base: &self.base[..],
             scalar: &mut self.scalar,
-            window_size: window_size,
+            window_size,
         }
     }
 
@@ -123,7 +123,7 @@ impl<G: CurveProjective> Wnaf<(), Vec<G>, Vec<i64>> {
         Wnaf {
             base: &mut self.base,
             scalar: &self.scalar[..],
-            window_size: window_size,
+            window_size,
         }
     }
 }