diff --git a/bellman/src/groth16/tests/dummy_engine.rs b/bellman/src/groth16/tests/dummy_engine.rs index 6c011c3..21322d8 100644 --- a/bellman/src/groth16/tests/dummy_engine.rs +++ b/bellman/src/groth16/tests/dummy_engine.rs @@ -423,7 +423,7 @@ impl CurveProjective for Fr { *self } - fn recommended_wnaf_for_scalar(_: ::Repr) -> usize { + fn recommended_wnaf_for_scalar(_: &::Repr) -> usize { 3 } diff --git a/group/src/lib.rs b/group/src/lib.rs index 34c8ac2..3dd9bbd 100644 --- a/group/src/lib.rs +++ b/group/src/lib.rs @@ -82,7 +82,7 @@ pub trait CurveProjective: /// Recommends a wNAF window table size given a scalar. Always returns a number /// between 2 and 22, inclusive. - fn recommended_wnaf_for_scalar(scalar: ::Repr) -> usize; + fn recommended_wnaf_for_scalar(scalar: &::Repr) -> usize; /// Recommends a wNAF window size given the number of scalars you intend to multiply /// a base by. Always returns a number between 2 and 22, inclusive. diff --git a/group/src/wnaf.rs b/group/src/wnaf.rs index 381cd10..70f880b 100644 --- a/group/src/wnaf.rs +++ b/group/src/wnaf.rs @@ -115,7 +115,7 @@ impl Wnaf<(), Vec, Vec> { scalar: <::Scalar as PrimeField>::Repr, ) -> Wnaf, &[i64]> { // Compute the appropriate window size for the scalar. - let window_size = G::recommended_wnaf_for_scalar(scalar); + let window_size = G::recommended_wnaf_for_scalar(&scalar); // Compute the wNAF form of the scalar. wnaf_form(&mut self.scalar, scalar, window_size); diff --git a/pairing/src/bls12_381/ec.rs b/pairing/src/bls12_381/ec.rs index a87fe11..2dae1ea 100644 --- a/pairing/src/bls12_381/ec.rs +++ b/pairing/src/bls12_381/ec.rs @@ -674,7 +674,7 @@ macro_rules! curve_impl { (*self).into() } - fn recommended_wnaf_for_scalar(scalar: ::Repr) -> usize { + fn recommended_wnaf_for_scalar(scalar: &::Repr) -> usize { Self::empirical_recommended_wnaf_for_scalar(scalar) } @@ -1014,7 +1014,7 @@ pub mod g1 { } impl G1 { - fn empirical_recommended_wnaf_for_scalar(scalar: FrRepr) -> usize { + fn empirical_recommended_wnaf_for_scalar(scalar: &FrRepr) -> usize { let num_bits = scalar.num_bits() as usize; if num_bits >= 130 { @@ -1733,7 +1733,7 @@ pub mod g2 { } impl G2 { - fn empirical_recommended_wnaf_for_scalar(scalar: FrRepr) -> usize { + fn empirical_recommended_wnaf_for_scalar(scalar: &FrRepr) -> usize { let num_bits = scalar.num_bits() as usize; if num_bits >= 103 {