diff --git a/bellman/src/gadgets/lookup.rs b/bellman/src/gadgets/lookup.rs index 0c55801..bbb1da6 100644 --- a/bellman/src/gadgets/lookup.rs +++ b/bellman/src/gadgets/lookup.rs @@ -154,7 +154,6 @@ where Ok(tmp) })?; - let one = CS::one(); // Compute the coefficients for the lookup constraints diff --git a/zcash_proofs/src/circuit/pedersen_hash.rs b/zcash_proofs/src/circuit/pedersen_hash.rs index 30ee06e..409f30e 100644 --- a/zcash_proofs/src/circuit/pedersen_hash.rs +++ b/zcash_proofs/src/circuit/pedersen_hash.rs @@ -26,7 +26,6 @@ where assert_eq!(personalization.len(), 6); let mut edwards_result = None; - //REVIEW: bit cloning let mut bits = personalization.iter().chain(bits.iter()).peekable(); let mut segment_generators = params.pedersen_circuit_generators().iter(); let boolean_false = Boolean::constant(false); @@ -41,7 +40,6 @@ where let b = bits.next().unwrap_or(&boolean_false); let c = bits.next().unwrap_or(&boolean_false); - let tmp = lookup3_xy_with_conditional_negation( cs.namespace(|| format!("segment {}, window {}", segment_i, window_i)), &[a.clone(), b.clone(), c.clone()], @@ -209,33 +207,4 @@ mod test { } } } - - #[test] - fn test_pedersen_hash_alternative() { - let params = &JubjubBls12::new(); - - let mut input: Vec = vec![]; - for i in 0..(63*3*4-6+1) { - input.push(true); - } - - let mut cs = TestConstraintSystem::::new(); - - - let input_bools: Vec = input.iter().enumerate().map(|(i, b)| { - Boolean::from( - AllocatedBit::alloc(cs.namespace(|| format!("input {}", i)), Some(*b)).unwrap() - ) - }).collect(); - let res = pedersen_hash( - cs.namespace(|| "pedersen hash"), - Personalization::Empty, - &input_bools, - params - ).unwrap(); - - assert!(cs.is_satisfied()); - println!("x={},y={}", res.get_x().get_value().unwrap(), res.get_y().get_value().unwrap()); - - } }