From e5ec3a6a95b57c63f75be7363bc9ac6e7f690f95 Mon Sep 17 00:00:00 2001 From: Andreas Schildbach Date: Tue, 28 Feb 2017 13:41:37 -0300 Subject: [PATCH] Transaction: Lower REFERENCE_DEFAULT_MIN_TX_FEE to 1000 and MIN_NONDUST_OUTPUT to 546. These limits are still a thing these days both for relaying and mining transactions. --- core/src/main/java/org/bitcoinj/core/Transaction.java | 4 ++-- core/src/test/java/org/bitcoinj/wallet/WalletTest.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/org/bitcoinj/core/Transaction.java b/core/src/main/java/org/bitcoinj/core/Transaction.java index 7038cb59..d5ce18f6 100644 --- a/core/src/main/java/org/bitcoinj/core/Transaction.java +++ b/core/src/main/java/org/bitcoinj/core/Transaction.java @@ -105,7 +105,7 @@ public class Transaction extends ChildMessage { /** * If feePerKb is lower than this, Bitcoin Core will treat it as if there were no fee. */ - public static final Coin REFERENCE_DEFAULT_MIN_TX_FEE = Coin.valueOf(5000); // 0.05 mBTC + public static final Coin REFERENCE_DEFAULT_MIN_TX_FEE = Coin.valueOf(1000); // 0.01 mBTC /** * If using this feePerKb, transactions will get confirmed within the next couple of blocks. @@ -118,7 +118,7 @@ public class Transaction extends ChildMessage { * This is calculated by assuming a standard output will be 34 bytes, and then using the formula used in * {@link TransactionOutput#getMinNonDustValue(Coin)}. */ - public static final Coin MIN_NONDUST_OUTPUT = Coin.valueOf(2730); // satoshis + public static final Coin MIN_NONDUST_OUTPUT = Coin.valueOf(546); // satoshis // These are bitcoin serialized. private long version; diff --git a/core/src/test/java/org/bitcoinj/wallet/WalletTest.java b/core/src/test/java/org/bitcoinj/wallet/WalletTest.java index fa1eb946..4a98b5d6 100644 --- a/core/src/test/java/org/bitcoinj/wallet/WalletTest.java +++ b/core/src/test/java/org/bitcoinj/wallet/WalletTest.java @@ -2690,7 +2690,7 @@ public class WalletTest extends TestWithWallet { @Test public void lowerThanDefaultFee() throws InsufficientMoneyException { - int feeFactor = 10; + int feeFactor = 50; Coin fee = Transaction.DEFAULT_TX_FEE.divide(feeFactor); receiveATransactionAmount(wallet, myAddress, Coin.COIN); SendRequest req = SendRequest.to(myAddress, Coin.CENT);