Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-02-12 10:15:52 +00:00
Code Issues Projects Releases Wiki Activity

Write+rename wallet files.

Browse Source
This commit is contained in:
Mike Hearn 2012-05-21 15:31:21 +02:00
parent 08f5630cf9
commit e42063806c
2 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
core/src/main/java/com/google/bitcoin/core/Wallet.java
View File

@ -19,6 +19,7 @@ package com.google.bitcoin.core;
import com.google.bitcoin.core.WalletTransaction.Pool; import com.google.bitcoin.core.WalletTransaction.Pool;
import com.google.bitcoin.store.WalletProtobufSerializer; import com.google.bitcoin.store.WalletProtobufSerializer;
import com.google.bitcoin.utils.EventListenerInvoker; import com.google.bitcoin.utils.EventListenerInvoker;
import com.google.common.base.Preconditions;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -180,15 +181,29 @@ public class Wallet implements Serializable {
/** /**
* Uses protobuf serialization to save the wallet to the given file. To learn more about this file format, see * Uses protobuf serialization to save the wallet to the given file. To learn more about this file format, see
* {@link WalletProtobufSerializer}. * {@link WalletProtobufSerializer}. Writes out first to a temporary file in the same directory and then renames
* once written.
*/ */
public synchronized void saveToFile(File f) throws IOException { public synchronized void saveToFile(File f) throws IOException {
Preconditions.checkArgument(f.isFile());
FileOutputStream stream = null; FileOutputStream stream = null;
File temp = null;
try { try {
stream = new FileOutputStream(f); File directory = f.getParentFile();
temp = File.createTempFile("wallet", null, directory);
stream = new FileOutputStream(temp);
saveToFileStream(stream); saveToFileStream(stream);
} finally { } finally {
if (stream != null) stream.close(); if (stream != null) {
// Attempt to force the bits to hit the disk. In reality the OS or hard disk itself may still decide
// to not write through to physical media for at least a few seconds, but this is the best we can do.
stream.flush();
stream.getFD().sync();
stream.close();
if (!temp.renameTo(f)) {
throw new IOException("Failed to rename " + temp + " to " + f);
}
}
} }
} }

11
tools/src/main/java/com/google/bitcoin/tools/WalletTool.java
View File

@ -524,16 +524,9 @@ public class WalletTool {
} }
private static void saveWallet(File walletFile) { private static void saveWallet(File walletFile) {
// Save the new state of the wallet to a temp file then rename, in case anything goes wrong.
File tmp;
try { try {
// Create tmp in same directory as wallet to ensure we create on the same drive/volume. // This will save the new state of the wallet to a temp file then rename, in case anything goes wrong.
tmp = File.createTempFile("wallet", null, walletFile.getParentFile()); wallet.saveToFile(walletFile);
tmp.deleteOnExit();
wallet.saveToFile(tmp);
if (!tmp.renameTo(walletFile)) {
throw new IOException("Failed to rename wallet");
}
} catch (IOException e) { } catch (IOException e) {
System.err.println("Failed to save wallet! Old wallet should be left untouched."); System.err.println("Failed to save wallet! Old wallet should be left untouched.");
e.printStackTrace(); e.printStackTrace();