From bf585d862734656e1db203ccea70a50b09ebdc40 Mon Sep 17 00:00:00 2001 From: Mike Hearn Date: Thu, 11 Jul 2013 16:52:11 +0200 Subject: [PATCH] Transaction: note that a ScriptException is expected at this point. --- core/src/main/java/com/google/bitcoin/core/Transaction.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/com/google/bitcoin/core/Transaction.java b/core/src/main/java/com/google/bitcoin/core/Transaction.java index cb771c51..4615815a 100644 --- a/core/src/main/java/com/google/bitcoin/core/Transaction.java +++ b/core/src/main/java/com/google/bitcoin/core/Transaction.java @@ -782,7 +782,9 @@ public class Transaction extends ChildMessage implements Serializable { input.getScriptSig().correctlySpends(this, i, input.getOutpoint().getConnectedOutput().getScriptPubKey(), true); log.warn("Input {} already correctly spends output, assuming SIGHASH type used will be safe and skipping signing.", i); continue; - } catch (ScriptException e) {} + } catch (ScriptException e) { + // Expected. + } if (input.getScriptBytes().length != 0) log.warn("Re-signing an already signed transaction! Be sure this is what you want."); // Find the signing key we'll need to use.