Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-02-13 02:35:52 +00:00
Code Issues Projects Releases Wiki Activity

Transaction: Limit initial size of inputs and outputs ArrayList.

Browse Source
This commit is contained in:
Oscar Guindzberg 2018-03-19 15:49:51 -03:00 committed by Andreas Schildbach
parent b976205716
commit afa14d6968
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/main/java/org/bitcoinj/core/Transaction.java
View File

@ -122,6 +122,11 @@ public class Transaction extends ChildMessage {
*/ */
public static final Coin MIN_NONDUST_OUTPUT = Coin.valueOf(546); // satoshis public static final Coin MIN_NONDUST_OUTPUT = Coin.valueOf(546); // satoshis
/**
* Max initial size of inputs and outputs ArrayList.
*/
public static final int MAX_INITIAL_INPUTS_OUTPUTS_SIZE = 20;
// These are bitcoin serialized. // These are bitcoin serialized.
private long version; private long version;
private ArrayList<TransactionInput> inputs; private ArrayList<TransactionInput> inputs;
@ -568,7 +573,7 @@ public class Transaction extends ChildMessage {
// First come the inputs. // First come the inputs.
long numInputs = readVarInt(); long numInputs = readVarInt();
optimalEncodingMessageSize += VarInt.sizeOf(numInputs); optimalEncodingMessageSize += VarInt.sizeOf(numInputs);
inputs = new ArrayList<>((int) numInputs); inputs = new ArrayList<>(Math.min((int) numInputs, MAX_INITIAL_INPUTS_OUTPUTS_SIZE));
for (long i = 0; i < numInputs; i++) { for (long i = 0; i < numInputs; i++) {
TransactionInput input = new TransactionInput(params, this, payload, cursor, serializer); TransactionInput input = new TransactionInput(params, this, payload, cursor, serializer);
inputs.add(input); inputs.add(input);
@ -579,7 +584,7 @@ public class Transaction extends ChildMessage {
// Now the outputs // Now the outputs
long numOutputs = readVarInt(); long numOutputs = readVarInt();
optimalEncodingMessageSize += VarInt.sizeOf(numOutputs); optimalEncodingMessageSize += VarInt.sizeOf(numOutputs);
outputs = new ArrayList<>((int) numOutputs); outputs = new ArrayList<>(Math.min((int) numOutputs, MAX_INITIAL_INPUTS_OUTPUTS_SIZE));
for (long i = 0; i < numOutputs; i++) { for (long i = 0; i < numOutputs; i++) {
TransactionOutput output = new TransactionOutput(params, this, payload, cursor, serializer); TransactionOutput output = new TransactionOutput(params, this, payload, cursor, serializer);
outputs.add(output); outputs.add(output);