diff --git a/core/src/main/java/org/bitcoinj/crypto/KeyCrypterScrypt.java b/core/src/main/java/org/bitcoinj/crypto/KeyCrypterScrypt.java index c631d37a..c9bc11fe 100644 --- a/core/src/main/java/org/bitcoinj/crypto/KeyCrypterScrypt.java +++ b/core/src/main/java/org/bitcoinj/crypto/KeyCrypterScrypt.java @@ -198,24 +198,24 @@ public class KeyCrypterScrypt implements KeyCrypter, Serializable { /** * Decrypt bytes previously encrypted with this class. * - * @param privateKeyToDecode The private key to decrypt + * @param dataToDecrypt The data to decrypt * @param aesKey The AES key to use for decryption * @return The decrypted bytes - * @throws KeyCrypterException if bytes could not be decoded to a valid key + * @throws KeyCrypterException if bytes could not be decrypted */ @Override - public byte[] decrypt(EncryptedData privateKeyToDecode, KeyParameter aesKey) throws KeyCrypterException { - checkNotNull(privateKeyToDecode); + public byte[] decrypt(EncryptedData dataToDecrypt, KeyParameter aesKey) throws KeyCrypterException { + checkNotNull(dataToDecrypt); checkNotNull(aesKey); try { - ParametersWithIV keyWithIv = new ParametersWithIV(new KeyParameter(aesKey.getKey()), privateKeyToDecode.initialisationVector); + ParametersWithIV keyWithIv = new ParametersWithIV(new KeyParameter(aesKey.getKey()), dataToDecrypt.initialisationVector); // Decrypt the message. BufferedBlockCipher cipher = new PaddedBufferedBlockCipher(new CBCBlockCipher(new AESFastEngine())); cipher.init(false, keyWithIv); - byte[] cipherBytes = privateKeyToDecode.encryptedBytes; + byte[] cipherBytes = dataToDecrypt.encryptedBytes; byte[] decryptedBytes = new byte[cipher.getOutputSize(cipherBytes.length)]; final int length1 = cipher.processBytes(cipherBytes, 0, cipherBytes.length, decryptedBytes, 0); final int length2 = cipher.doFinal(decryptedBytes, length1); diff --git a/core/src/test/java/org/bitcoinj/crypto/KeyCrypterScryptTest.java b/core/src/test/java/org/bitcoinj/crypto/KeyCrypterScryptTest.java index add5129b..38f4f400 100644 --- a/core/src/test/java/org/bitcoinj/crypto/KeyCrypterScryptTest.java +++ b/core/src/test/java/org/bitcoinj/crypto/KeyCrypterScryptTest.java @@ -63,11 +63,11 @@ public class KeyCrypterScryptTest { KeyCrypterScrypt keyCrypter = new KeyCrypterScrypt(scryptParameters); // Encrypt. - EncryptedData encryptedPrivateKey = keyCrypter.encrypt(TEST_BYTES1, keyCrypter.deriveKey(PASSWORD1)); - assertNotNull(encryptedPrivateKey); + EncryptedData data = keyCrypter.encrypt(TEST_BYTES1, keyCrypter.deriveKey(PASSWORD1)); + assertNotNull(data); // Decrypt. - byte[] reborn = keyCrypter.decrypt(encryptedPrivateKey, keyCrypter.deriveKey(PASSWORD1)); + byte[] reborn = keyCrypter.decrypt(data, keyCrypter.deriveKey(PASSWORD1)); log.debug("Original: " + Utils.HEX.encode(TEST_BYTES1)); log.debug("Reborn : " + Utils.HEX.encode(reborn)); assertEquals(Utils.HEX.encode(TEST_BYTES1), Utils.HEX.encode(reborn)); @@ -90,11 +90,11 @@ public class KeyCrypterScryptTest { String plainText = UUID.randomUUID().toString(); CharSequence password = UUID.randomUUID().toString(); - EncryptedData encryptedPrivateKey = keyCrypter.encrypt(plainText.getBytes(), keyCrypter.deriveKey(password)); + EncryptedData data = keyCrypter.encrypt(plainText.getBytes(), keyCrypter.deriveKey(password)); - assertNotNull(encryptedPrivateKey); + assertNotNull(data); - byte[] reconstructedPlainBytes = keyCrypter.decrypt(encryptedPrivateKey,keyCrypter.deriveKey(password)); + byte[] reconstructedPlainBytes = keyCrypter.decrypt(data,keyCrypter.deriveKey(password)); assertEquals(Utils.HEX.encode(plainText.getBytes()), Utils.HEX.encode(reconstructedPlainBytes)); System.out.print('.'); } @@ -128,11 +128,11 @@ public class KeyCrypterScryptTest { KeyCrypterScrypt keyCrypter = new KeyCrypterScrypt(scryptParameters); // Encrypt bytes. - EncryptedData encryptedPrivateKey = keyCrypter.encrypt(TEST_BYTES1, keyCrypter.deriveKey(PASSWORD1)); - assertNotNull(encryptedPrivateKey); - log.debug("\nEncrypterDecrypterTest: cipherBytes = \nlength = " + encryptedPrivateKey.encryptedBytes.length + "\n---------------\n" + Utils.HEX.encode(encryptedPrivateKey.encryptedBytes) + "\n---------------\n"); + EncryptedData data = keyCrypter.encrypt(TEST_BYTES1, keyCrypter.deriveKey(PASSWORD1)); + assertNotNull(data); + log.debug("\nEncrypterDecrypterTest: cipherBytes = \nlength = " + data.encryptedBytes.length + "\n---------------\n" + Utils.HEX.encode(data.encryptedBytes) + "\n---------------\n"); - byte[] rebornPlainBytes = keyCrypter.decrypt(encryptedPrivateKey, keyCrypter.deriveKey(PASSWORD1)); + byte[] rebornPlainBytes = keyCrypter.decrypt(data, keyCrypter.deriveKey(PASSWORD1)); log.debug("Original: " + Utils.HEX.encode(TEST_BYTES1)); log.debug("Reborn1 : " + Utils.HEX.encode(rebornPlainBytes)); @@ -150,11 +150,11 @@ public class KeyCrypterScryptTest { byte[] plainBytes = new byte[i]; random.nextBytes(plainBytes); - EncryptedData encryptedPrivateKey = keyCrypter.encrypt(plainBytes, keyCrypter.deriveKey(PASSWORD1)); - assertNotNull(encryptedPrivateKey); + EncryptedData data = keyCrypter.encrypt(plainBytes, keyCrypter.deriveKey(PASSWORD1)); + assertNotNull(data); //log.debug("\nEncrypterDecrypterTest: cipherBytes = \nlength = " + cipherBytes.length + "\n---------------\n" + Utils.HEX.encode(cipherBytes) + "\n---------------\n"); - byte[] rebornPlainBytes = keyCrypter.decrypt(encryptedPrivateKey, keyCrypter.deriveKey(PASSWORD1)); + byte[] rebornPlainBytes = keyCrypter.decrypt(data, keyCrypter.deriveKey(PASSWORD1)); log.debug("Original: (" + i + ") " + Utils.HEX.encode(plainBytes)); log.debug("Reborn1 : (" + i + ") " + Utils.HEX.encode(rebornPlainBytes));