From 82fb22a88456f25d3f4cc8510e656d866a5a3406 Mon Sep 17 00:00:00 2001 From: Andreas Schildbach Date: Fri, 2 Jun 2017 16:22:19 +0200 Subject: [PATCH] Transaction: Fix two null pointer access warnings. --- core/src/main/java/org/bitcoinj/core/Transaction.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/org/bitcoinj/core/Transaction.java b/core/src/main/java/org/bitcoinj/core/Transaction.java index df53a1e9..7165b850 100644 --- a/core/src/main/java/org/bitcoinj/core/Transaction.java +++ b/core/src/main/java/org/bitcoinj/core/Transaction.java @@ -680,8 +680,9 @@ public class Transaction extends ChildMessage { try { Script scriptSig = in.getScriptSig(); s.append(scriptSig); - if (in.getValue() != null) - s.append(" ").append(in.getValue().toFriendlyString()); + final Coin value = in.getValue(); + if (value != null) + s.append(" ").append(value.toFriendlyString()); s.append("\n "); s.append("outpoint:"); final TransactionOutPoint outpoint = in.getOutpoint(); @@ -719,9 +720,10 @@ public class Transaction extends ChildMessage { if (!out.isAvailableForSpending()) { s.append(" Spent"); } - if (out.getSpentBy() != null) { + final TransactionInput spentBy = out.getSpentBy(); + if (spentBy != null) { s.append(" by "); - s.append(out.getSpentBy().getParentTransaction().getHashAsString()); + s.append(spentBy.getParentTransaction().getHashAsString()); } } catch (Exception e) { s.append("[exception: ").append(e.getMessage()).append("]");